Skip to content

Incorrect handling of eclass pr's #4

@xxc3nsoredxx

Description

@xxc3nsoredxx

I noticed a bit back that PR's which are just eclasses [1] (at least) confuses the bot.

The following bits seem to work correctly:

  • submitter info
  • areas affected info
  • packages affected info

The following bits seem incorrect or incomplete:

  • tagging maintainers

    • "@gentoo/github" is tagged (arthurzam pointed out in -dev on IRC that it tags a team in the org with that)
    • it should be possible to extract the maintainer info out of the eclass since it uses a standardized format
  • labels

    • the PR is tagged as "needs assignment" presumably due to the failed maintainer detection
  • new packages blurb

    • the example PR does not introduce any new packages, so gets added erroneously

Linking bugs probably works, but my example doesn't have any bugs attached to it.

1: https://web.archive.org/web/20230810035704/https://github.com/gentoo/gentoo/pull/32111

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions