delete AddLegacyMetrics

Author: phnx47

src/MetricServer.cs

@@ -31,25 +31,17 @@ public MetricServer()
     /// </summary>
     public MetricServer(MetricServerOptions options)
     {
-        if (options == null)
-            throw new ArgumentNullException(nameof(options));
+        ArgumentNullException.ThrowIfNull(options);
 
-        if (!options.MapPath.StartsWith("/"))
+        if (!options.MapPath.StartsWith('/'))
             options.MapPath = "/" + options.MapPath;
 
         _options = options;
 
         _options.CollectorRegistry ??= Metrics.DefaultCollectorRegistry;
 
         if (_options.UseDefaultCollectors)
-        {
-#pragma warning disable CS0618
-            if (options.AddLegacyMetrics)
-                options.CollectorRegistry.UseDefaultCollectors(options.MetricPrefixName, options.AddLegacyMetrics);
-            else
-                options.CollectorRegistry.UseDefaultCollectors(options.MetricPrefixName);
-#pragma warning restore CS0618
-        }
+            options.CollectorRegistry.UseDefaultCollectors(options.MetricPrefixName);
     }
 
     /// <inheritdoc />

src/MetricServerOptions.cs

@@ -49,19 +49,4 @@ public class MetricServerOptions
     ///     Metric prefix for Default collectors
     /// </summary>
     public string MetricPrefixName { get; set; } = string.Empty;
-
-    /// <summary>
-    ///     Add legacy metrics to Default collectors
-    /// </summary>
-    ///  <remarks>
-    ///     Some metrics renamed since v5, <c>AddLegacyMetrics</c> will add old and new name<br />
-    ///     <para>
-    ///       process_virtual_bytes -> process_virtual_memory_bytes<br />
-    ///       process_private_bytes -> process_private_memory_bytes<br />
-    ///       process_working_set -> process_working_set_bytes<br />
-    ///       dotnet_totalmemory -> dotnet_total_memory_bytes
-    ///     </para>
-    /// </remarks>
-    [Obsolete("'AddLegacyMetrics' will be removed in future versions")]
-    public bool AddLegacyMetrics { get; set; }
 }

tests/MetricServerTests.cs

@@ -186,57 +186,6 @@ public async Task CustomCounter_FindMetric()
         }
     }
 
-    [Fact]
-    public async Task AddLegacyMetrics_False_FindMetrics()
-    {
-        try
-        {
-            _metricServer.Start();
-            using var httpClient = new HttpClient();
-            string response = await httpClient.GetStringAsync($"http://localhost:{fixture.Port}{Defaults.MapPath}", TestContext.Current.CancellationToken);
-            Assert.Contains("process_private_memory_bytes", response);
-            Assert.Contains("dotnet_total_memory_bytes", response);
-            Assert.DoesNotContain("process_private_bytes", response);
-            Assert.DoesNotContain("dotnet_totalmemory", response);
-        }
-        catch (Exception ex)
-        {
-            testOutputHelper.WriteLine(ex.ToString());
-            throw;
-        }
-        finally
-        {
-            _metricServer.Stop();
-        }
-    }
-
-    [Fact]
-    public async Task AddLegacyMetrics_True_FindMetrics()
-    {
-        _metricServer = new MetricServer(new MetricServerOptions
-            { Port = fixture.Port, CollectorRegistry = new CollectorRegistry(), AddLegacyMetrics = true });
-
-        try
-        {
-            _metricServer.Start();
-            using var httpClient = new HttpClient();
-            string response = await httpClient.GetStringAsync($"http://localhost:{fixture.Port}{Defaults.MapPath}", TestContext.Current.CancellationToken);
-            Assert.Contains("process_private_memory_bytes", response);
-            Assert.Contains("dotnet_total_memory_bytes", response);
-            Assert.Contains("process_private_bytes", response);
-            Assert.Contains("dotnet_totalmemory", response);
-        }
-        catch (Exception ex)
-        {
-            testOutputHelper.WriteLine(ex.ToString());
-            throw;
-        }
-        finally
-        {
-            _metricServer.Stop();
-        }
-    }
-
     [Fact]
     public async Task WrongUrl_NotFound()
     {