#2: fix .net core example

Author: phnx47

README.md

@@ -30,25 +30,25 @@ Or Standalone this:
 
 ```csharp
 
-[HttpGet]
-public IActionResult Get()
-{
-    var registry = CollectorRegistry.Instance;
-    var acceptHeaders = Request.Headers["Accept"];
-    var contentType = ScrapeHandler.GetContentType(acceptHeaders);
-    Response.ContentType = contentType;
-    string content;
-
-    using (var outputStream = new MemoryStream())
+    [Route("[controller]")]
+    public class MetricsController : Controller
     {
-        var collected = registry.CollectAll();
-        ScrapeHandler.ProcessScrapeRequest(collected, contentType, outputStream);
-        content = Encoding.UTF8.GetString(outputStream.ToArray());
+        [HttpGet]
+        public void Get()
+        {
+            var registry = CollectorRegistry.Instance;
+            var acceptHeaders = Request.Headers["Accept"];
+            var contentType = ScrapeHandler.GetContentType(acceptHeaders);
+            Response.ContentType = contentType;
+            Response.StatusCode = 200;
+            using (var outputStream = Response.Body)
+            {
+                var collected = registry.CollectAll();
+                ScrapeHandler.ProcessScrapeRequest(collected, contentType, outputStream);
+            }
+        }
     }
 
-    return Ok(content);
-}
-
 ```
 
 

examples/WebApiApplication/Controllers/MetricsController.cs

@@ -1,6 +1,7 @@
 using System.IO;
 using System.Net;
 using System.Net.Http;
+using System.Net.Http.Headers;
 using System.Net.Mime;
 using System.Text;
 using System.Web.Http;
@@ -19,17 +20,22 @@ public HttpResponseMessage Get()
 
             var contentType = ScrapeHandler.GetContentType(acceptHeaders);
 
-            var response = Request.CreateResponse(HttpStatusCode.OK);
+         
             string content;
 
             using (var outputStream = new MemoryStream())
             {
                 var collected = registry.CollectAll();
                 ScrapeHandler.ProcessScrapeRequest(collected, contentType, outputStream);
-                content = Encoding.UTF8.GetString(outputStream.ToArray());
+                content = Encoding.ASCII.GetString(outputStream.ToArray());
             }
 
-            response.Content = new StringContent(content, Encoding.UTF8, new ContentType(contentType).MediaType);
+
+            var response = Request.CreateResponse(HttpStatusCode.OK);
+
+            response.Content = new StringContent(content, Encoding.UTF8, contentType);
+
+
             return response;
 
         }

examples/WebCoreApplication/Controllers/MetricsController.cs

@@ -11,22 +11,18 @@ namespace WebCoreApplication.Controllers
     public class MetricsController : Controller
     {
         [HttpGet]
-        public IActionResult Get()
+        public void Get()
         {
             var registry = CollectorRegistry.Instance;
             var acceptHeaders = Request.Headers["Accept"];
             var contentType = ScrapeHandler.GetContentType(acceptHeaders);
             Response.ContentType = contentType;
-            string content;
-
-            using (var outputStream = new MemoryStream())
+            Response.StatusCode = 200;
+            using (var outputStream = Response.Body)
             {
                 var collected = registry.CollectAll();
                 ScrapeHandler.ProcessScrapeRequest(collected, contentType, outputStream);
-                content = Encoding.UTF8.GetString(outputStream.ToArray());
             }
-
-            return Ok(content);
         }
     }
 }

examples/WebCoreApplication/Properties/launchSettings.json

@@ -23,7 +23,7 @@
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"
       },
-      "applicationUrl": "http://localhost:25049"
+      "applicationUrl": "http://localhost:5000"
     }
   }
 }