Update Go

* Update minimum Go version to 1.24.0.
* Update Go to 1.25.
* Run Go modernize tool.

Signed-off-by: SuperQ <superq@gmail.com>

Author: SuperQ

.circleci/config.yml

@@ -7,7 +7,7 @@ executors:
   # also be updated.
   golang:
     docker:
-      - image: cimg/go:1.23
+      - image: cimg/go:1.25
 jobs:
   test:
     executor: golang

.promu.yml

@@ -1,6 +1,6 @@
 go:
     # This must match .circle/config.yml.
-    version: 1.23
+    version: 1.25
 repository:
     path: github.com/prometheus-community/bind_exporter
 build:

bind/json/json.go

@@ -88,7 +88,7 @@ func NewClient(url string, c *http.Client) *Client {
 // Get queries the given path and stores the result in the value pointed to by
 // v. The endpoint must return a valid JSON representation which can be
 // unmarshaled into the provided value.
-func (c *Client) Get(p string, v interface{}) error {
+func (c *Client) Get(p string, v any) error {
 	u, err := url.Parse(c.url)
 	if err != nil {
 		return fmt.Errorf("invalid URL %q: %s", c.url, err)

bind/xml/xml.go

@@ -103,7 +103,7 @@ func NewClient(url string, c *http.Client) *Client {
 // Get queries the given path and stores the result in the value pointed to by
 // v. The endpoint must return a valid XML representation which can be
 // unmarshaled into the provided value.
-func (c *Client) Get(p string, v interface{}) error {
+func (c *Client) Get(p string, v any) error {
 	u, err := url.Parse(c.url)
 	if err != nil {
 		return fmt.Errorf("invalid URL %q: %s", c.url, err)

bind_exporter.go

@@ -20,6 +20,7 @@ import (
 	"net/http"
 	_ "net/http/pprof"
 	"os"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -504,7 +505,7 @@ func (s *statisticGroups) Set(value string) error {
 		return nil
 	}
 	var sg bind.StatisticGroup
-	for _, dt := range strings.Split(value, ",") {
+	for dt := range strings.SplitSeq(value, ",") {
 		switch dt {
 		case string(bind.ServerStats):
 			sg = bind.ServerStats
@@ -515,10 +516,8 @@ func (s *statisticGroups) Set(value string) error {
 		default:
 			return fmt.Errorf("unknown stats group %q", dt)
 		}
-		for _, existing := range *s {
-			if existing == sg {
-				return fmt.Errorf("duplicated stats group %q", sg)
-			}
+		if slices.Contains(*s, sg) {
+			return fmt.Errorf("duplicated stats group %q", sg)
 		}
 		*s = append(*s, sg)
 	}

go.mod

@@ -1,6 +1,6 @@
 module github.com/prometheus-community/bind_exporter
 
-go 1.23.0
+go 1.24.0
 
 require (
 	github.com/alecthomas/kingpin/v2 v2.4.0