[prometheus-cloudwatch-exporter] Adding commonLabels functionality that adds labels to all #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Burgos <[email protected]>
tincho-burgos
requested review from
asherf,
gianrubio and
torstenwalter
as code owners
|
Hi @asherf @gianrubio @torstenwalter, |
Signed-off-by: Martin Burgos <[email protected]>
|
Hi @asherf @gianrubio @torstenwalter, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Burgos [email protected]
What this PR does / why we need it
Easier way to add labels to all K8S resources the chart is creating.
Which issue this PR fixes
N/A
Special notes for your reviewer
I am adding the block commonLabels to have an easier way of adding labels to the resources, when required.
Checklist
[prometheus-couchdb-exporter])