Smart - reports using /dev/sda-z rather than anything that uniquely identifies the drive ?

[simonmcnair]

I think, but I'm unsure (and apologies if i am wrong), that the smart details are exported using /dev/sda-sdz rather than wwn, or anything in /dev/disk/by-id ?

This means that if Linux reads the disks in a different order, or the disk is swapped out that the data attached to that label will be incorrect ?

Is there an easy way to correlate the model/serial/wwn as an additional field along with /dev/[sda-z] so that you can easily and uniquely correlate the data to another disk ?

Sorry if I am incorrect, or out of place, but I thought the question was worth asking.
Cheers

[dswarbrick]

Neither the smartmon.py nor the deprecated smartmon.sh collector exposes the WWN. It would probably be a useful addition to the smartmon_device_info metric. In the meantime, at least the serial number is included in that metric already.

[vazhnov]

I also think that path like /dev/disk/by-id/ata-Patriot_Burst_D9AE0702054800009323 is unique and human-readable, it has the device name and serial number:

alexey@pve03 ~ % sudo find -L /dev -xdev -samefile /dev/sda      
/dev/disk/by-diskseq/9
/dev/disk/by-path/pci-0000:00:11.0-ata-1.0
/dev/disk/by-path/pci-0000:00:11.0-ata-1
/dev/disk/by-id/ata-Patriot_Burst_D9AE0702054800009323
/dev/block/8:0
/dev/sda

There is already a solution: #135!

But in my Debian 12, file /usr/share/prometheus-node-exporter-collectors/smartmon.py, installed by package prometheus-node-exporter-collectors , doesn't have the improvement #135, because of version 0.0~git20230203.6f710f8-1+deb12u2: https://tracker.debian.org/pkg/prometheus-node-exporter-collectors 😞

If you have fresh version of smartmon.py, then probably it is needed to edit the Systemd service configuration:

sudo systemctl edit prometheus-node-exporter-smartmon.service

and there adjust ExecStart, for example:

[Service]
ExecStart=
ExecStart=/bin/bash -c "/usr/share/prometheus-node-exporter-collectors/smartmon.py --by-id | sponge /var/lib/prometheus/node-exporter/smartmon.prom"

(yes, double ExecStart is needed to rewrite the old value).

If you've just copied the fresh Python script into Debian 12, also install a package python3-prometheus-client to avoid an error:

Traceback (most recent call last):
File "/usr/share/prometheus-node-exporter-collectors/smartmon_NEW_6b36c81.py", line 10, in
from prometheus_client import CollectorRegistry, Gauge, generate_latest
ModuleNotFoundError: No module named 'prometheus_client'

[vazhnov]

Still node_disk_* metrics are using /dev/sdX format:

alexey@pve03 ~ % curl -sS pve03.local:9100/metrics | grep sda
node_disk_ata_rotation_rate_rpm{device="sda"} 0
node_disk_ata_write_cache{device="sda"} 1
node_disk_ata_write_cache_enabled{device="sda"} 1
node_disk_discard_time_seconds_total{device="sda"} 1.808
node_disk_discarded_sectors_total{device="sda"} 4.1336412e+08
node_disk_discards_completed_total{device="sda"} 20951
node_disk_discards_merged_total{device="sda"} 0
node_disk_flush_requests_time_seconds_total{device="sda"} 159.001
node_disk_flush_requests_total{device="sda"} 297984
node_disk_info{device="sda",major="8",minor="0",model="Patriot_Burst",path="pci-0000:00:11.0-ata-1.0",revision="SBFM61.3",serial="D9AE0702054800009323",wwn=""} 1
node_disk_io_now{device="sda"} 0
node_disk_io_time_seconds_total{device="sda"} 809.362
node_disk_io_time_weighted_seconds_total{device="sda"} 1857.412
node_disk_read_bytes_total{device="sda"} 6.2735308288e+10
node_disk_read_time_seconds_total{device="sda"} 378.88100000000003
node_disk_reads_completed_total{device="sda"} 633635
node_disk_reads_merged_total{device="sda"} 56237
node_disk_write_time_seconds_total{device="sda"} 1317.72
node_disk_writes_completed_total{device="sda"} 1.335575e+06
node_disk_writes_merged_total{device="sda"} 845386
node_disk_written_bytes_total{device="sda"} 2.1555534848e+10
node_filesystem_device_error{device="/dev/sda2",fstype="vfat",mountpoint="/boot/efi"} 0
…