File tree Expand file tree Collapse file tree 2 files changed +12
-3
lines changed Expand file tree Collapse file tree 2 files changed +12
-3
lines changed Original file line number Diff line number Diff line change 1919 steps :
2020 - name : git checkout
2121 uses : actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
22+ with :
23+ persist-credentials : false
2224 - name : Set docker hub repo name
2325 run : echo "DOCKER_REPO_NAME=$(make docker-repo-name)" >> $GITHUB_ENV
2426 - name : Push README to Dockerhub
4143 steps :
4244 - name : git checkout
4345 uses : actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
46+ with :
47+ persist-credentials : false
4448 - name : Set quay.io org name
4549 run : echo "DOCKER_REPO=$(echo quay.io/${GITHUB_REPOSITORY_OWNER} | tr -d '-')" >> $GITHUB_ENV
4650 - name : Set quay.io repo name
Original file line number Diff line number Diff line change @@ -62,6 +62,7 @@ SKIP_GOLANGCI_LINT :=
6262GOLANGCI_LINT :=
6363GOLANGCI_LINT_OPTS ?=
6464GOLANGCI_LINT_VERSION ?= v2.1.5
65+ GOLANGCI_FMT_OPTS ?=
6566# golangci-lint only supports linux, darwin and windows platforms on i386/amd64/arm64.
6667# windows isn't included here because of the path separator being different.
6768ifeq ($(GOHOSTOS),$(filter $(GOHOSTOS),linux darwin))
@@ -156,9 +157,13 @@ $(GOTEST_DIR):
156157 @mkdir -p $@
157158
158159.PHONY: common-format
159- common-format:
160+ common-format: $(GOLANGCI_LINT)
160161 @echo ">> formatting code"
161162 $(GO) fmt $(pkgs)
163+ ifdef GOLANGCI_LINT
164+ @echo ">> formatting code with golangci-lint"
165+ $(GOLANGCI_LINT) fmt $(GOLANGCI_FMT_OPTS)
166+ endif
162167
163168.PHONY: common-vet
164169common-vet:
@@ -248,8 +253,8 @@ $(PROMU):
248253 cp $(PROMU_TMP)/promu-$(PROMU_VERSION).$(GO_BUILD_PLATFORM)/promu $(FIRST_GOPATH)/bin/promu
249254 rm -r $(PROMU_TMP)
250255
251- .PHONY: proto
252- proto:
256+ .PHONY: common- proto
257+ common- proto:
253258 @echo ">> generating code from proto files"
254259 @./scripts/genproto.sh
255260
You can’t perform that action at this time.
0 commit comments