Skip to content

Commit fb7877f

Browse files
committed
jsonnet: do not hide alerting configuration
Signed-off-by: paulfantom <[email protected]>
1 parent cf7b892 commit fb7877f

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

jsonnet/kube-prometheus/components/prometheus.libsonnet

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
1-
local defaults = spec {
1+
local defaults = {
22
local defaults = self,
33
// Convention: Top-level fields related to CRDs are public, other fields are hidden
44
// If there is no CRD for the component, everything is hidden in defaults.
5+
name:: error 'must provide name',
56
namespace:: error 'must provide namespace',
67
version: error 'must provide version',
78
image: error 'must provide image',
89
resources: {
910
requests: { memory: '400Mi' },
1011
},
11-
12-
name:: error 'must provide name',
13-
//TODO: remove alertmanagerName and convert to plain 'alerting' object
14-
alertmanagerName:: error 'must provide alertmanagerName',
12+
//TODO(paulfantom): remove alertmanagerName after release-0.10 and convert to plain 'alerting' object.
13+
alertmanagerName:: "",
14+
alerting: {},
1515
namespaces:: ['default', 'kube-system', defaults.namespace],
1616
replicas: 2,
1717
externalLabels: {},
1818
enableFeatures: [],
19+
ruleSelector: {},
1920
commonLabels:: {
2021
'app.kubernetes.io/name': 'prometheus',
2122
'app.kubernetes.io/version': defaults.version,
@@ -27,7 +28,6 @@ local defaults = spec {
2728
for labelName in std.objectFields(defaults.commonLabels)
2829
if !std.setMember(labelName, ['app.kubernetes.io/version'])
2930
} + { prometheus: defaults.name },
30-
ruleSelector: {},
3131
mixin:: {
3232
ruleLabels: {},
3333
_config: {
@@ -273,7 +273,7 @@ function(params) {
273273
serviceMonitorNamespaceSelector: {},
274274
nodeSelector: { 'kubernetes.io/os': 'linux' },
275275
resources: p._config.resources,
276-
alerting: {
276+
alerting: if p._config.alerting != {} then p._config.alerting else {
277277
alertmanagers: [{
278278
namespace: p._config.namespace,
279279
name: 'alertmanager-' + p._config.alertmanagerName,

jsonnet/kube-prometheus/main.libsonnet

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,14 @@ local utils = import './lib/utils.libsonnet';
9191
version: $.values.common.versions.prometheus,
9292
image: $.values.common.images.prometheus,
9393
name: 'k8s',
94-
alertmanagerName: $.values.alertmanager.name,
94+
alerting: {
95+
alertmanagers: [{
96+
namespace: $.values.common.namespace,
97+
name: 'alertmanager-' + $.values.alertmanager.name,
98+
port: $.alertmanager.service.spec.ports[0].name,
99+
apiVersion: 'v2',
100+
}],
101+
},
95102
mixin+: { ruleLabels: $.values.common.ruleLabels },
96103
},
97104
prometheusAdapter: {

0 commit comments

Comments
 (0)