refactor: use b.Loop() to simplify the code and improve performance (#4642)

Signed-off-by: promalert <[email protected]>

Author: promalert

inhibit/inhibit_bench_test.go

@@ -204,9 +204,8 @@ func benchmarkMutes(b *testing.B, opts benchmarkOptions) {
 
 	// Wait some time for the inhibitor to seed its cache.
 	<-time.After(time.Second)
-	b.ResetTimer()
 
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		require.NoError(b, opts.benchFunc(ih.Mutes))
 	}
 }

matcher/parse/bench_test.go

@@ -23,15 +23,15 @@ const (
 )
 
 func BenchmarkParseSimple(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		if _, err := Matchers(simpleExample); err != nil {
 			b.Fatal(err)
 		}
 	}
 }
 
 func BenchmarkParseComplex(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		if _, err := Matchers(complexExample); err != nil {
 			b.Fatal(err)
 		}

notify/notify_test.go

@@ -1076,7 +1076,7 @@ func BenchmarkHashAlert(b *testing.B) {
 			Labels: model.LabelSet{"foo": "the_first_value", "bar": "the_second_value", "another": "value"},
 		},
 	}
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		hashAlert(alert)
 	}
 }

silence/silence_bench_test.go

@@ -76,8 +76,7 @@ func benchmarkMutes(b *testing.B, n int) {
 	m := types.NewMarker(prometheus.NewRegistry())
 	s := NewSilencer(silences, m, promslog.NewNopLogger())
 
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		s.Mutes(model.LabelSet{"foo": "bar"})
 	}
 	b.StopTimer()
@@ -145,8 +144,7 @@ func benchmarkQuery(b *testing.B, numSilences int) {
 	require.NoError(b, err)
 	require.Len(b, sils, numSilences/10)
 
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		sils, _, err := s.Query(
 			QState(types.SilenceStateActive),
 			QMatches(lset),