test: lean towards table driven testing

To improve readability of the test.

Signed-off-by: emreya <[email protected]>

Author: eyazici90

notify/pagerduty/pagerduty_test.go

@@ -507,54 +507,60 @@ func TestPagerDutyTimeout(t *testing.T) {
 		Links       []pagerDutyLink
 	}
 
-	latency := time.Millisecond * 50
-	srv := httptest.NewServer(http.HandlerFunc(
-		func(w http.ResponseWriter, r *http.Request) {
-			decoder := json.NewDecoder(r.Body)
-			var event pagerDutyEvent
-			if err := decoder.Decode(&event); err != nil {
-				panic(err)
-			}
-
-			if event.RoutingKey == "" || event.EventAction == "" {
-				http.Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest)
-				return
-			}
-			time.Sleep(latency)
-		},
-	))
-	defer srv.Close()
-	url, err := url.Parse(srv.URL)
-	require.NoError(t, err)
+	tests := map[string]struct {
+		latency time.Duration
+		timeout time.Duration
+		wantErr bool
+	}{
+		"success": {latency: 100 * time.Millisecond, timeout: 120 * time.Millisecond, wantErr: false},
+		"error":   {latency: 100 * time.Millisecond, timeout: 80 * time.Millisecond, wantErr: true},
+	}
 
-	f := func(ts time.Duration) error {
-		cfg := config.PagerdutyConfig{
-			HTTPConfig: &commoncfg.HTTPClientConfig{},
-			RoutingKey: config.Secret("01234567890123456789012345678901"),
-			URL:        &config.URL{URL: url},
-			Timeout:    ts,
-		}
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+
+			srv := httptest.NewServer(http.HandlerFunc(
+				func(w http.ResponseWriter, r *http.Request) {
+					decoder := json.NewDecoder(r.Body)
+					var event pagerDutyEvent
+					if err := decoder.Decode(&event); err != nil {
+						panic(err)
+					}
+
+					if event.RoutingKey == "" || event.EventAction == "" {
+						http.Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest)
+						return
+					}
+					time.Sleep(tt.latency)
+				},
+			))
+			defer srv.Close()
+			u, err := url.Parse(srv.URL)
+			require.NoError(t, err)
 
-		pd, err := New(&cfg, test.CreateTmpl(t), promslog.NewNopLogger())
-		require.NoError(t, err)
+			cfg := config.PagerdutyConfig{
+				HTTPConfig: &commoncfg.HTTPClientConfig{},
+				RoutingKey: config.Secret("01234567890123456789012345678901"),
+				URL:        &config.URL{URL: u},
+				Timeout:    tt.timeout,
+			}
 
-		ctx := context.Background()
-		ctx = notify.WithGroupKey(ctx, "1")
+			pd, err := New(&cfg, test.CreateTmpl(t), promslog.NewNopLogger())
+			require.NoError(t, err)
 
-		_, err = pd.Notify(ctx, &types.Alert{
-			Alert: model.Alert{
-				Labels: model.LabelSet{
-					"lbl1": "val1",
+			ctx := context.Background()
+			ctx = notify.WithGroupKey(ctx, "1")
+			alert := &types.Alert{
+				Alert: model.Alert{
+					Labels: model.LabelSet{
+						"lbl1": "val1",
+					},
+					StartsAt: time.Now(),
+					EndsAt:   time.Now().Add(time.Hour),
 				},
-				StartsAt: time.Now(),
-				EndsAt:   time.Now().Add(time.Hour),
-			}},
-		)
-		return err
+			}
+			_, err = pd.Notify(ctx, alert)
+			require.Equal(t, tt.wantErr, err != nil)
+		})
 	}
-
-	err = f(latency - time.Millisecond*10)
-	require.Error(t, err)
-	err = f(latency + time.Millisecond*10)
-	require.NoError(t, err)
 }