Merge pull request #793 from johncming/stdlib-constant

Replace with the standard library constant.

Author: beorn7

api/prometheus/v1/api.go

@@ -117,8 +117,6 @@ func marshalPointJSONIsEmpty(ptr unsafe.Pointer) bool {
 }
 
 const (
-	statusAPIError = 422
-
 	apiPrefix = "/api/v1"
 
 	epAlerts          = apiPrefix + "/alerts"
@@ -943,7 +941,7 @@ type apiResponse struct {
 
 func apiError(code int) bool {
 	// These are the codes that Prometheus sends when it returns an error.
-	return code == statusAPIError || code == http.StatusBadRequest
+	return code == http.StatusUnprocessableEntity || code == http.StatusBadRequest
 }
 
 func errorTypeAndMsgFor(resp *http.Response) (ErrorType, string) {

api/prometheus/v1/api_test.go

@@ -84,7 +84,7 @@ func (c *apiTestClient) Do(ctx context.Context, req *http.Request) (*http.Respon
 	if test.inStatusCode != 0 {
 		resp.StatusCode = test.inStatusCode
 	} else if test.inErr != nil {
-		resp.StatusCode = statusAPIError
+		resp.StatusCode = http.StatusUnprocessableEntity
 	} else {
 		resp.StatusCode = http.StatusOK
 	}
@@ -1118,7 +1118,7 @@ func (c *testClient) Do(ctx context.Context, req *http.Request) (*http.Response,
 func TestAPIClientDo(t *testing.T) {
 	tests := []apiClientTest{
 		{
-			code: statusAPIError,
+			code: http.StatusUnprocessableEntity,
 			response: &apiResponse{
 				Status:    "error",
 				Data:      json.RawMessage(`null`),
@@ -1132,7 +1132,7 @@ func TestAPIClientDo(t *testing.T) {
 			expectedBody: `null`,
 		},
 		{
-			code: statusAPIError,
+			code: http.StatusUnprocessableEntity,
 			response: &apiResponse{
 				Status:    "error",
 				Data:      json.RawMessage(`"test"`),
@@ -1177,15 +1177,15 @@ func TestAPIClientDo(t *testing.T) {
 			},
 		},
 		{
-			code:     statusAPIError,
+			code:     http.StatusUnprocessableEntity,
 			response: "bad json",
 			expectedErr: &Error{
 				Type: ErrBadResponse,
 				Msg:  "readObjectStart: expect { or n, but found b, error found in #1 byte of ...|bad json|..., bigger context ...|bad json|...",
 			},
 		},
 		{
-			code: statusAPIError,
+			code: http.StatusUnprocessableEntity,
 			response: &apiResponse{
 				Status: "success",
 				Data:   json.RawMessage(`"test"`),
@@ -1196,7 +1196,7 @@ func TestAPIClientDo(t *testing.T) {
 			},
 		},
 		{
-			code: statusAPIError,
+			code: http.StatusUnprocessableEntity,
 			response: &apiResponse{
 				Status:    "success",
 				Data:      json.RawMessage(`"test"`),