Skip to content

Commit 77b35d0

Browse files
authored
Merge pull request #783 from roidelapluie/gc15
Update collector comment about GC stop-the-world
2 parents d3accfd + 4759649 commit 77b35d0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

prometheus/go_collector.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,10 @@ type goCollector struct {
5858
// collector will use the memstats from a previous collection if
5959
// runtime.ReadMemStats takes more than 1s. However, if there are no previously
6060
// collected memstats, or their collection is more than 5m ago, the collection
61-
// will block until runtime.ReadMemStats succeeds. (The problem might be solved
62-
// in Go1.13, see https://github.com/golang/go/issues/19812 for the related Go
63-
// issue.)
61+
// will block until runtime.ReadMemStats succeeds.
62+
//
63+
// NOTE: The problem is solved in Go 1.15, see
64+
// https://github.com/golang/go/issues/19812 for the related Go issue.
6465
func NewGoCollector() Collector {
6566
return &goCollector{
6667
goroutinesDesc: NewDesc(

0 commit comments

Comments
 (0)