nullaway

Signed-off-by: Gregor Zeitlinger <[email protected]>

Author: zeitlinger

prometheus-metrics-config/src/test/java/io/prometheus/metrics/config/ExporterPushgatewayPropertiesTest.java

@@ -32,4 +32,20 @@ void load() {
   private static ExporterPushgatewayProperties load(Map<String, String> map) {
     return ExporterPushgatewayProperties.load(new HashMap<>(map));
   }
+
+  @Test
+  void builder() {
+    ExporterPushgatewayProperties properties =
+        ExporterPushgatewayProperties.builder()
+            .address("http://localhost")
+            .job("job")
+            .scheme("http")
+            .escapingScheme(EscapingScheme.DOTS_ESCAPING)
+            .build();
+
+    assertThat(properties.getAddress()).isEqualTo("http://localhost");
+    assertThat(properties.getJob()).isEqualTo("job");
+    assertThat(properties.getScheme()).isEqualTo("http");
+    assertThat(properties.getEscapingScheme()).isEqualTo(EscapingScheme.DOTS_ESCAPING);
+  }
 }

prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/exemplars/ExemplarSampler.java

@@ -55,7 +55,7 @@ public ExemplarSampler(ExemplarSamplerConfig config) {
    * io.prometheus.metrics.tracer.initializer.SpanContextSupplier#getSpanContext()
    * SpanContextSupplier.getSpanContext()} is called to find a span context.
    */
-  public ExemplarSampler(ExemplarSamplerConfig config, SpanContext spanContext) {
+  public ExemplarSampler(ExemplarSamplerConfig config, @Nullable  SpanContext spanContext) {
     this.config = config;
     this.exemplars = new Exemplar[config.getNumberOfExemplars()];
     this.customExemplars = new Exemplar[exemplars.length];

prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/OpenMetricsTextFormatWriter.java

@@ -346,17 +346,21 @@ private void writeCreated(Writer writer, MetricMetadata metadata, DataPointSnaps
     }
   }
 
-  private void writeNameAndLabels(Writer writer, String name, String suffix, Labels labels)
+  private void writeNameAndLabels(
+      Writer writer,
+      String name,
+      @Nullable String suffix,
+      Labels labels)
       throws IOException {
     writeNameAndLabels(writer, name, suffix, labels, null, 0.0);
   }
 
   private void writeNameAndLabels(
       Writer writer,
       String name,
-      String suffix,
+      @Nullable String suffix,
       Labels labels,
-      String additionalLabelName,
+      @Nullable String additionalLabelName,
       double additionalLabelValue)
       throws IOException {
     writer.write(name);

prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/PrometheusTextFormatWriter.java

@@ -26,6 +26,7 @@
 import java.io.OutputStreamWriter;
 import java.io.Writer;
 import java.nio.charset.StandardCharsets;
+import javax.annotation.Nullable;
 
 /**
  * Write the Prometheus text format. This is the default if you view a Prometheus endpoint with your
@@ -344,17 +345,21 @@ private void writeUnknown(Writer writer, UnknownSnapshot snapshot) throws IOExce
     }
   }
 
-  private void writeNameAndLabels(Writer writer, String name, String suffix, Labels labels)
+  private void writeNameAndLabels(
+      Writer writer,
+      String name,
+      @Nullable String suffix,
+      Labels labels)
       throws IOException {
     writeNameAndLabels(writer, name, suffix, labels, null, 0.0);
   }
 
   private void writeNameAndLabels(
       Writer writer,
       String name,
-      String suffix,
+      @Nullable String suffix,
       Labels labels,
-      String additionalLabelName,
+      @Nullable String additionalLabelName,
       double additionalLabelValue)
       throws IOException {
     writer.write(name);
@@ -368,7 +373,8 @@ private void writeNameAndLabels(
   }
 
   private void writeMetadata(
-      Writer writer, String suffix, String typeString, MetricMetadata metadata) throws IOException {
+      Writer writer,
+      @Nullable String suffix, String typeString, MetricMetadata metadata) throws IOException {
     if (metadata.getHelp() != null && !metadata.getHelp().isEmpty()) {
       writer.write("# HELP ");
       writer.write(metadata.getPrometheusName());

prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/TextFormatUtil.java

@@ -3,6 +3,7 @@
 import io.prometheus.metrics.model.snapshots.Labels;
 import java.io.IOException;
 import java.io.Writer;
+import javax.annotation.Nullable;
 
 public class TextFormatUtil {
 
@@ -99,7 +100,9 @@ static void writeEscapedLabelValue(Writer writer, String s) throws IOException {
   }
 
   static void writeLabels(
-      Writer writer, Labels labels, String additionalLabelName, double additionalLabelValue)
+      Writer writer,
+      Labels labels,
+      @Nullable String additionalLabelName, double additionalLabelValue)
       throws IOException {
     writer.write('{');
     for (int i = 0; i < labels.size(); i++) {