Skip to content

Commit 0f32c67

Browse files
Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.30 to 11.0.0 (#1146)
* Bump org.apache.tomcat.embed:tomcat-embed-core from 10.1.30 to 11.0.0 Bumps org.apache.tomcat.embed:tomcat-embed-core from 10.1.30 to 11.0.0. --- updated-dependencies: - dependency-name: org.apache.tomcat.embed:tomcat-embed-core dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * fix tomcat Signed-off-by: Gregor Zeitlinger <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Gregor Zeitlinger <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gregor Zeitlinger <[email protected]>
1 parent c9ff46b commit 0f32c67

File tree

6 files changed

+20
-5
lines changed
  • examples
    • example-exemplars-tail-sampling
    • example-exporter-servlet-tomcat
  • integration-tests/it-exporter

6 files changed

+20
-5
lines changed

examples/example-exemplars-tail-sampling/example-greeting-service/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<dependency>
3939
<groupId>org.apache.tomcat.embed</groupId>
4040
<artifactId>tomcat-embed-core</artifactId>
41-
<version>10.1.30</version>
41+
<version>11.0.0</version>
4242
</dependency>
4343
</dependencies>
4444

examples/example-exemplars-tail-sampling/example-hello-world-app/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<dependency>
3939
<groupId>org.apache.tomcat.embed</groupId>
4040
<artifactId>tomcat-embed-core</artifactId>
41-
<version>10.1.30</version>
41+
<version>11.0.0</version>
4242
</dependency>
4343
</dependencies>
4444

examples/example-exporter-servlet-tomcat/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<dependency>
3939
<groupId>org.apache.tomcat.embed</groupId>
4040
<artifactId>tomcat-embed-core</artifactId>
41-
<version>10.1.30</version>
41+
<version>11.0.0</version>
4242
</dependency>
4343
</dependencies>
4444

integration-tests/it-exporter/it-exporter-servlet-tomcat-sample/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<dependency>
3434
<groupId>org.apache.tomcat.embed</groupId>
3535
<artifactId>tomcat-embed-core</artifactId>
36-
<version>10.1.30</version>
36+
<version>11.0.0</version>
3737
</dependency>
3838
</dependencies>
3939

integration-tests/it-exporter/it-exporter-test/src/test/java/io/prometheus/metrics/it/exporter/test/ExporterIT.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,10 @@ public void testErrorHandling() throws IOException {
176176
assertThat(new String(response.body, UTF_8)).contains("Simulating an error.");
177177
}
178178

179+
protected boolean headReturnsContentLength() {
180+
return true;
181+
}
182+
179183
@Test
180184
public void testHeadRequest() throws IOException {
181185
sampleAppContainer
@@ -186,7 +190,11 @@ public void testHeadRequest() throws IOException {
186190
assertThat(size > 0).isTrue();
187191
Response headResponse = scrape("HEAD", "");
188192
assertThat(headResponse.status).isEqualTo(200);
189-
assertThat(headResponse.getHeader("Content-Length")).isEqualTo(Integer.toString(size));
193+
if (headReturnsContentLength()) {
194+
assertThat(headResponse.getHeader("Content-Length")).isEqualTo(Integer.toString(size));
195+
} else {
196+
assertThat(headResponse.getHeader("Content-Length")).isNull();
197+
}
190198
assertThat(headResponse.body.length).isZero();
191199
}
192200

integration-tests/it-exporter/it-exporter-test/src/test/java/io/prometheus/metrics/it/exporter/test/TomcatIT.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,11 @@ class TomcatIT extends ExporterIT {
77
public TomcatIT() throws IOException, URISyntaxException {
88
super("exporter-servlet-tomcat-sample");
99
}
10+
11+
@Override
12+
protected boolean headReturnsContentLength() {
13+
// not any more since
14+
// https://tomcat.apache.org/tomcat-11.0-doc/changelog.html#Tomcat_11.0.0-M3_(markt)
15+
return false;
16+
}
1017
}

0 commit comments

Comments
 (0)