Skip to content

Commit 203361e

Browse files
committed
format
Signed-off-by: Gregor Zeitlinger <[email protected]>
1 parent e61f127 commit 203361e

File tree

6 files changed

+10
-14
lines changed

6 files changed

+10
-14
lines changed

prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/PrometheusProperties.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ public ExporterOpenTelemetryProperties getExporterOpenTelemetryProperties() {
100100
return exporterOpenTelemetryProperties;
101101
}
102102

103-
104103
public static class Builder {
105104
private MetricsProperties defaultMetricsProperties;
106105
private Map<String, MetricsProperties> metricProperties = new HashMap<>();
@@ -161,7 +160,6 @@ public Builder exporterOpenTelemetryProperties(
161160
return this;
162161
}
163162

164-
165163
public PrometheusProperties build() {
166164
return new PrometheusProperties(
167165
defaultMetricsProperties,

prometheus-metrics-exporter-pushgateway/src/test/java/io/prometheus/metrics/exporter/pushgateway/PushGatewayTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,13 @@
88
import io.prometheus.metrics.core.metrics.Gauge;
99
import io.prometheus.metrics.model.registry.PrometheusRegistry;
1010
import io.prometheus.metrics.model.snapshots.EscapingScheme;
11-
import io.prometheus.metrics.model.snapshots.PrometheusNaming;
1211
import java.io.IOException;
1312
import java.lang.reflect.Field;
1413
import java.net.InetAddress;
1514
import java.net.URL;
1615
import org.junit.jupiter.api.AfterEach;
1716
import org.junit.jupiter.api.BeforeEach;
1817
import org.junit.jupiter.api.Test;
19-
import org.junitpioneer.jupiter.SetSystemProperty;
2018
import org.mockserver.client.MockServerClient;
2119
import org.mockserver.integration.ClientAndServer;
2220

prometheus-metrics-exposition-textformats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.io.ByteArrayOutputStream;
2929
import java.io.IOException;
3030
import java.util.concurrent.atomic.AtomicInteger;
31-
3231
import org.junit.jupiter.api.Test;
3332
import org.junit.jupiter.params.ParameterizedTest;
3433
import org.junit.jupiter.params.provider.CsvSource;
@@ -476,8 +475,8 @@ public void testGaugeUTF8() throws IOException {
476475
"""
477476
# HELP "gauge.name" gauge\\ndoc\\nstr"ing
478477
# TYPE "gauge.name" gauge
479-
{"gauge.name","name*2"="val with \\\\backslash and \\"quotes\\"","name.1"="val with\\nnew line"} +Inf
480-
{"gauge.name","name*2"="佖佥","name.1"="Björn"} 3.14E42
478+
{"gauge.name","name.1"="Björn","name*2"="佖佥"} 3.14E42
479+
{"gauge.name","name.1"="val with\\nnew line","name*2"="val with \\\\backslash and \\"quotes\\""} +Inf
481480
""";
482481
GaugeSnapshot gauge =
483482
GaugeSnapshot.builder()

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/CounterSnapshot.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.util.ArrayList;
44
import java.util.Collection;
55
import java.util.List;
6+
import javax.annotation.Nullable;
67

78
/** Immutable snapshot of a Counter. */
89
public class CounterSnapshot extends MetricSnapshot {
@@ -97,7 +98,7 @@ public Builder value(double value) {
9798
return this;
9899
}
99100

100-
public Builder exemplar(Exemplar exemplar) {
101+
public Builder exemplar(@Nullable Exemplar exemplar) {
101102
this.exemplar = exemplar;
102103
return this;
103104
}

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/PrometheusNaming.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package io.prometheus.metrics.model.snapshots;
22

3-
import javax.annotation.Nullable;
4-
53
import static java.lang.Character.MAX_CODE_POINT;
64
import static java.lang.Character.MAX_LOW_SURROGATE;
75
import static java.lang.Character.MIN_HIGH_SURROGATE;
@@ -11,6 +9,7 @@
119
import java.util.List;
1210
import java.util.regex.Matcher;
1311
import java.util.regex.Pattern;
12+
import javax.annotation.Nullable;
1413

1514
/**
1615
* Utility for Prometheus Metric and Label naming.
@@ -449,13 +448,15 @@ private static DataPointSnapshot createEscapedDataPointSnapshot(
449448
private static Exemplars escapeExemplars(Exemplars exemplars, EscapingScheme scheme) {
450449
List<Exemplar> escapedExemplars = new ArrayList<>(exemplars.size());
451450
for (Exemplar exemplar : exemplars) {
452-
Exemplar escaped = escapeExemplar(exemplar, scheme);
453-
escapedExemplars.add(escaped);
451+
escapedExemplars.add(escapeExemplar(exemplar, scheme));
454452
}
455453
return Exemplars.of(escapedExemplars);
456454
}
457455

458-
private static Exemplar escapeExemplar(Exemplar exemplar, EscapingScheme scheme) {
456+
private static Exemplar escapeExemplar(@Nullable Exemplar exemplar, EscapingScheme scheme) {
457+
if (exemplar == null) {
458+
return null;
459+
}
459460
return Exemplar.builder()
460461
.labels(escapeLabels(exemplar.getLabels(), scheme))
461462
.timestampMillis(exemplar.getTimestampMillis())

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
1515

1616
import java.util.stream.Stream;
17-
1817
import org.junit.jupiter.api.Test;
1918
import org.junit.jupiter.params.ParameterizedTest;
2019
import org.junit.jupiter.params.provider.Arguments;

0 commit comments

Comments
 (0)