Skip to content

Commit 25b91e6

Browse files
committed
PrometheusNaming changes were incompatible - so deprecating instead
Signed-off-by: Gregor Zeitlinger <[email protected]>
1 parent 39d7f3e commit 25b91e6

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamesTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,4 +204,18 @@ void testValidMetricName() {
204204
assertThat(PrometheusNames.isValidMetricName("invalid_metric_name_total")).isFalse();
205205
assertThat(PrometheusNames.isValidMetricName("0abc.def")).isTrue();
206206
}
207+
208+
@Test
209+
void testValidLabelName() {
210+
assertThat(PrometheusNames.isValidLabelName("valid_label_name")).isTrue();
211+
assertThat(PrometheusNames.isValidLabelName("0invalid_label_name")).isTrue();
212+
assertThat(PrometheusNames.isValidLabelName("invalid-label-name")).isTrue();
213+
}
214+
215+
@Test
216+
void testValidUnitName() {
217+
assertThat(PrometheusNames.isValidUnitName("seconds")).isTrue();
218+
assertThat(PrometheusNames.isValidUnitName("seconds_total")).isFalse();
219+
assertThat(PrometheusNames.isValidUnitName("2")).isTrue();
220+
}
207221
}

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamingTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,4 +126,18 @@ void testValidMetricName() {
126126
assertThat(PrometheusNaming.isValidMetricName("invalid_metric_name_total")).isFalse();
127127
assertThat(PrometheusNaming.isValidMetricName("0abc.def")).isFalse();
128128
}
129+
130+
@Test
131+
void testValidLabelName() {
132+
assertThat(PrometheusNaming.isValidLabelName("valid_label_name")).isTrue();
133+
assertThat(PrometheusNaming.isValidLabelName("0invalid_label_name")).isFalse();
134+
assertThat(PrometheusNaming.isValidLabelName("invalid-label-name")).isFalse();
135+
}
136+
137+
@Test
138+
void testValidUnitName() {
139+
assertThat(PrometheusNaming.isValidUnitName("seconds")).isTrue();
140+
assertThat(PrometheusNaming.isValidUnitName("seconds_total")).isFalse();
141+
assertThat(PrometheusNaming.isValidUnitName("2")).isTrue();
142+
}
129143
}

0 commit comments

Comments
 (0)