don't validate in escape

Signed-off-by: Gregor Zeitlinger <[email protected]>

Author: zeitlinger

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/SnapshotEscaperTest.java

@@ -5,7 +5,11 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.util.Objects;
+import java.util.stream.Stream;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 
 class SnapshotEscaperTest {
 
@@ -125,15 +129,25 @@ private MetricSnapshot createTestSnapshot(
     throw new IllegalArgumentException("Unsupported snapshot type: " + snapshotType);
   }
 
-  @Test
-  void escapeIsNoop() {
-    MetricSnapshot original = CounterSnapshot.builder().name("empty").build();
+  @ParameterizedTest
+  @MethodSource("emptySnapshots")
+  void escapeIsNoop(MetricSnapshot original) {
     assertThat(original)
         .isSameAs(escapeMetricSnapshot(original, EscapingScheme.NO_ESCAPING))
         .isSameAs(escapeMetricSnapshot(original, EscapingScheme.UNDERSCORE_ESCAPING));
     assertThat(escapeMetricSnapshot(null, EscapingScheme.NO_ESCAPING)).isNull();
   }
 
+  public static Stream<Arguments> emptySnapshots() {
+    return Stream.of(
+        Arguments.of(CounterSnapshot.builder().name("empty").build()),
+        Arguments.of(GaugeSnapshot.builder().name("empty").build()),
+        Arguments.of(SummarySnapshot.builder().name("empty").build()),
+        Arguments.of(HistogramSnapshot.builder().name("empty").build()),
+        Arguments.of(StateSetSnapshot.builder().name("empty").build()),
+        Arguments.of(UnknownSnapshot.builder().name("empty").build()));
+  }
+
   @Test
   void metadataName() {
     MetricMetadata metadata = new MetricMetadata("test.");

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/SummarySnapshotTest.java

@@ -110,4 +110,11 @@ public void testEmptyData() {
     assertThat(data.hasScrapeTimestamp()).isFalse();
     assertThat(data.getExemplars().size()).isZero();
   }
+
+  @Test
+  void escape() {
+    SummarySnapshot.SummaryDataPointSnapshot data =
+        SummarySnapshot.SummaryDataPointSnapshot.builder().build();
+    assertThat(data.escape(EscapingScheme.UNDERSCORE_ESCAPING)).isEqualTo(data);
+  }
 }