coverage

Signed-off-by: Gregor Zeitlinger <[email protected]>

Author: zeitlinger

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/SnapshotEscaper.java

@@ -15,7 +15,8 @@ public class SnapshotEscaper {
   private SnapshotEscaper() {}
 
   /** Escapes the given metric names and labels with the given escaping scheme. */
-  public static MetricSnapshot escapeMetricSnapshot(MetricSnapshot v, EscapingScheme scheme) {
+  @Nullable
+  public static MetricSnapshot escapeMetricSnapshot(@Nullable MetricSnapshot v, EscapingScheme scheme) {
     if (v == null) {
       return null;
     }
@@ -338,7 +339,7 @@ public static String escapeName(String name, EscapingScheme scheme) {
     }
   }
 
-  private static boolean needsEscaping(String name, EscapingScheme scheme) {
+  public static boolean needsEscaping(String name, EscapingScheme scheme) {
     return !PrometheusNaming.isValidLegacyMetricName(name)
         || (scheme == EscapingScheme.DOTS_ESCAPING && (name.contains(".") || name.contains("_")));
   }

prometheus-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/SnapshotEscaperTest.java

@@ -2,6 +2,7 @@
 
 import static io.prometheus.metrics.model.snapshots.SnapshotEscaper.escapeMetricSnapshot;
 import static io.prometheus.metrics.model.snapshots.SnapshotEscaper.escapeName;
+import static io.prometheus.metrics.model.snapshots.SnapshotEscaper.getSnapshotLabelName;
 import static io.prometheus.metrics.model.snapshots.SnapshotEscaper.unescapeName;
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -282,4 +283,30 @@ private MetricSnapshot createTestSnapshot(
 
     throw new IllegalArgumentException("Unsupported snapshot type: " + snapshotType);
   }
+
+  @Test
+  void escapeIsNoop() {
+    MetricSnapshot original = CounterSnapshot.builder().name("empty").build();
+    assertThat(original)
+        .isSameAs(escapeMetricSnapshot(original, EscapingScheme.NO_ESCAPING))
+        .isSameAs(escapeMetricSnapshot(original, EscapingScheme.UNDERSCORE_ESCAPING));
+    assertThat(escapeMetricSnapshot(null, EscapingScheme.NO_ESCAPING)).isNull();
+  }
+
+  @Test
+  void metadataName() {
+    MetricMetadata metadata = new MetricMetadata("test.");
+    assertThat(SnapshotEscaper.getMetadataName(metadata, EscapingScheme.NO_ESCAPING))
+        .isEqualTo("test.");
+    assertThat(SnapshotEscaper.getMetadataName(metadata, EscapingScheme.UNDERSCORE_ESCAPING))
+        .isEqualTo("test_");
+  }
+
+  @Test
+  void snapshotLabelName() {
+    Labels labels = Labels.builder().label("test.", "value").build();
+    assertThat(getSnapshotLabelName(labels, 0, EscapingScheme.NO_ESCAPING)).isEqualTo("test.");
+    assertThat(getSnapshotLabelName(labels, 0, EscapingScheme.UNDERSCORE_ESCAPING))
+        .isEqualTo("test_");
+  }
 }