Skip to content

Commit c5b70bc

Browse files
committed
coverage
Signed-off-by: Gregor Zeitlinger <[email protected]>
1 parent 6498aca commit c5b70bc

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

prometheus-metrics-config/src/test/java/io/prometheus/metrics/config/PrometheusPropertiesTest.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import java.io.IOException;
66
import java.io.InputStream;
7+
import java.util.Collections;
78
import java.util.HashMap;
89
import java.util.Properties;
910
import org.junit.jupiter.api.Test;
@@ -37,15 +38,20 @@ public void testBuilder() {
3738
PrometheusProperties defaults = PrometheusPropertiesLoader.load(new HashMap<>());
3839
PrometheusProperties.Builder builder = PrometheusProperties.builder();
3940
builder.defaultMetricsProperties(defaults.getDefaultMetricProperties());
41+
builder.metricProperties(
42+
Collections.singletonMap(
43+
"http_duration_seconds",
44+
MetricsProperties.builder().histogramClassicUpperBounds(0.1, 0.2, 0.5, 1.0).build()));
4045
builder.exemplarProperties(defaults.getExemplarProperties());
4146
builder.defaultMetricsProperties(defaults.getDefaultMetricProperties());
4247
builder.exporterFilterProperties(defaults.getExporterFilterProperties());
4348
builder.exporterHttpServerProperties(defaults.getExporterHttpServerProperties());
4449
builder.exporterOpenTelemetryProperties(defaults.getExporterOpenTelemetryProperties());
4550
builder.pushgatewayProperties(defaults.getExporterPushgatewayProperties());
51+
builder.exporterProperties(defaults.getExporterProperties());
52+
builder.namingProperties(defaults.getNamingProperties());
4653
PrometheusProperties result = builder.build();
4754
assertThat(result.getDefaultMetricProperties()).isSameAs(defaults.getDefaultMetricProperties());
48-
assertThat(result.getDefaultMetricProperties()).isSameAs(defaults.getDefaultMetricProperties());
4955
assertThat(result.getExemplarProperties()).isSameAs(defaults.getExemplarProperties());
5056
assertThat(result.getExporterFilterProperties())
5157
.isSameAs(defaults.getExporterFilterProperties());
@@ -55,5 +61,11 @@ public void testBuilder() {
5561
.isSameAs(defaults.getExporterOpenTelemetryProperties());
5662
assertThat(result.getExporterPushgatewayProperties())
5763
.isSameAs(defaults.getExporterPushgatewayProperties());
64+
assertThat(result.getMetricProperties("http_duration_seconds"))
65+
.isEqualTo(
66+
MetricsProperties.builder().histogramClassicUpperBounds(0.1, 0.2, 0.5, 1.0).build());
67+
assertThat(result.getMetricProperties("unknown_metric")).isNull();
68+
assertThat(result.getExporterProperties()).isSameAs(defaults.getExporterProperties());
69+
assertThat(result.getNamingProperties()).isSameAs(defaults.getNamingProperties());
5870
}
5971
}

0 commit comments

Comments
 (0)