prom name can't be null

Signed-off-by: Gregor Zeitlinger <[email protected]>

Author: zeitlinger

prometheus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/PrometheusNaming.java

@@ -385,15 +385,10 @@ public static MetricSnapshot escapeMetricSnapshot(MetricSnapshot v, EscapingSche
       return v;
     }
 
-    String outName;
-
-    // If the name is null, copy as-is, don't try to escape.
-    if (v.getMetadata().getPrometheusName() == null
-        || isValidLegacyMetricName(v.getMetadata().getPrometheusName())) {
-      outName = v.getMetadata().getPrometheusName();
-    } else {
-      outName = escapeName(v.getMetadata().getPrometheusName(), scheme);
-    }
+    String outName =
+        isValidLegacyMetricName(v.getMetadata().getPrometheusName())
+            ? v.getMetadata().getPrometheusName()
+            : escapeName(v.getMetadata().getPrometheusName(), scheme);
 
     List<DataPointSnapshot> outDataPoints = new ArrayList<>();