Skip to content

Commit fbb6ae7

Browse files
committed
Update shaded dependencies in BOM
Signed-off-by: Fabian Stäber <[email protected]>
1 parent 71cf428 commit fbb6ae7

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

MAINTAINER_NOTES.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ Step 3: Update `prometheus-metrics-exporter-opentelemetry`
3636
* Change the version of the `prometheus-metrics-shaded-opentelemetry` dependency in `pom.xml` to `${project.version}`.
3737
* Use find-and-replace to update the version numbers in the imported package names in the source code of `prometheus-metrics-exporter-opentelemetry`.
3838

39-
Step 4: Release
39+
Step 4: Update `prometheus-metrics-bom`
40+
41+
* Set the shaded dependency version property to `${project.version}` in `prometheus-metrics-bom/pom.xml`
42+
43+
Step 5: Release
4044

4145
_see below_
4246

@@ -45,7 +49,7 @@ _see below_
4549
Create a commit to temporarily add shaded dependencies to the project:
4650

4751
* Add the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
48-
* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
52+
* Change the versions of the shaded dependencies to `${project.version}` in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.
4953

5054
Release:
5155

@@ -61,4 +65,4 @@ After that, manually verify the uploaded artifacts on [https://oss.sonatype.org/
6165
Create a commit to remove dependencies from the build (undoing the first step):
6266

6367
* Comment out the `prometheus-metrics-shaded-dependencies` module to the root `pom.xml`.
64-
* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry` and `prometheus-metrics-exposition-formats`.
68+
* Change the versions of the shaded dependencies to the latest released version on Maven Central in `prometheus-metrics-exporter-opentelemetry`, `prometheus-metrics-exposition-formats`, and `prometheus-metrics-bom`.

prometheus-metrics-bom/pom.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,17 +118,20 @@
118118
<dependency>
119119
<groupId>io.prometheus</groupId>
120120
<artifactId>prometheus-metrics-shaded-dependencies</artifactId>
121-
<version>${prometheus.metrics.shaded.dependencies.version}</version>
121+
<!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
122+
<version>${project.version}</version>
122123
</dependency>
123124
<dependency>
124125
<groupId>io.prometheus</groupId>
125126
<artifactId>prometheus-metrics-shaded-protobuf</artifactId>
126-
<version>${prometheus.metrics.shaded.dependencies.version}</version>
127+
<!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
128+
<version>${project.version}</version>
127129
</dependency>
128130
<dependency>
129131
<groupId>io.prometheus</groupId>
130132
<artifactId>prometheus-metrics-shaded-opentelemetry</artifactId>
131-
<version>${prometheus.metrics.shaded.dependencies.version}</version>
133+
<!-- <version>${prometheus.metrics.shaded.dependencies.version}</version> -->
134+
<version>${project.version}</version>
132135
</dependency>
133136
</dependencies>
134137
</dependencyManagement>

0 commit comments

Comments
 (0)