Skip to content

Commit 01d2b4a

Browse files
committed
Remove unnecessary else and use NewSyncWriter again
Signed-off-by: Jan-Otto Kröpke <[email protected]>
1 parent 769f5e1 commit 01d2b4a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

promlog/log.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ type Config struct {
112112
// with a timestamp. The output always goes to stderr.
113113
func New(config *Config) log.Logger {
114114
if config.Format != nil && config.Format.s == "json" {
115-
return NewWithLogger(log.NewJSONLogger(os.Stderr), config)
116-
} else {
117-
return NewWithLogger(log.NewLogfmtLogger(os.Stderr), config)
115+
return NewWithLogger(log.NewJSONLogger(log.NewSyncWriter(os.Stderr)), config)
118116
}
117+
118+
return NewWithLogger(log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr)), config)
119119
}
120120

121121
// NewWithLogger returns a new leveled oklog logger with a custom log.Logger.
@@ -135,10 +135,10 @@ func NewWithLogger(l log.Logger, config *Config) log.Logger {
135135
// changed, like the level.
136136
func NewDynamic(config *Config) *logger {
137137
if config.Format != nil && config.Format.s == "json" {
138-
return NewDynamicWithLogger(log.NewJSONLogger(os.Stderr), config)
139-
} else {
140-
return NewDynamicWithLogger(log.NewLogfmtLogger(os.Stderr), config)
138+
return NewDynamicWithLogger(log.NewJSONLogger(log.NewSyncWriter(os.Stderr)), config)
141139
}
140+
141+
return NewDynamicWithLogger(log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr)), config)
142142
}
143143

144144
// NewDynamicWithLogger returns a new leveled logger with a custom io.Writer.

0 commit comments

Comments
 (0)