Merge pull request #448 from roidelapluie/test442

expfmt: add test case for issue with *bufio.Reader and FmtText format

Author: Julien Pivotto

expfmt/decode_test.go

@@ -14,6 +14,7 @@
 package expfmt
 
 import (
+	"bufio"
 	"io"
 	"net/http"
 	"reflect"
@@ -491,3 +492,33 @@ func TestExtractSamples(t *testing.T) {
 		t.Errorf("unexpected samples extracted, got: %v, want: %v", got, want)
 	}
 }
+
+func TestTextDecoderWithBufioReader(t *testing.T) {
+	example := `
+	# TYPE foo gauge
+	foo 0
+	`
+
+	var decoded bool
+	r := bufio.NewReader(strings.NewReader(example))
+	dec := NewDecoder(r, FmtText)
+	for {
+		var mf dto.MetricFamily
+		if err := dec.Decode(&mf); err != nil {
+			if err == io.EOF {
+				break
+			}
+			t.Fatalf("Unexpected error: %v", err)
+		}
+		if mf.GetName() != "foo" {
+			t.Errorf("Unexpected metric name: got %v, expected %v", mf.GetName(), "foo")
+		}
+		if len(mf.Metric) != 1 {
+			t.Errorf("Unexpected number of metrics: got %v, expected %v", len(mf.Metric), 1)
+		}
+		decoded = true
+	}
+	if !decoded {
+		t.Fatal("Metric foo not decoded")
+	}
+}