Skip to content

Commit f595ac6

Browse files
authored
Merge pull request #759 from m1k1o/feature/test-validation-with-dots
New test for validation with dots
2 parents 5ef1ac5 + aa9255c commit f595ac6

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

model/labels_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,11 @@ func TestValidationScheme_IsLabelNameValid(t *testing.T) {
142142
legacyValid: false,
143143
utf8Valid: false,
144144
},
145+
{
146+
ln: "dot.in.name",
147+
legacyValid: false,
148+
utf8Valid: true,
149+
},
145150
{
146151
ln: "",
147152
legacyValid: false,

model/metric_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,11 @@ func TestValidationScheme_IsMetricNameValid(t *testing.T) {
348348
legacyValid: false,
349349
utf8Valid: false,
350350
},
351+
{
352+
mn: "dot.in.name",
353+
legacyValid: false,
354+
utf8Valid: true,
355+
},
351356
}
352357
for _, s := range scenarios {
353358
t.Run(fmt.Sprintf("%s,%t,%t", s.mn, s.legacyValid, s.utf8Valid), func(t *testing.T) {

0 commit comments

Comments
 (0)