Skip to content

Commit 9c3a8c3

Browse files
committed
fix(om2): consistency between model and exposition
The model said that: A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata. However the exposition does not require it to be exposed, therefore for the sake of consistency we make this SHOULD. Also having all caps conflated the model with the exposition. Also this allows very simple exposers to not think about this. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
1 parent d6947bf commit 9c3a8c3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/specs/om/open_metrics_spec_2_0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ If more than one MetricPoint is exposed for a Metric, then its MetricPoints MUST
148148

149149
#### MetricFamily
150150

151-
A MetricFamily MAY have zero or more Metrics. A MetricFamily MUST have a name, HELP, TYPE, and UNIT metadata. Every Metric within a MetricFamily MUST have a unique LabelSet.
151+
A MetricFamily MAY have zero or more Metrics. Every Metric within a MetricFamily MUST have a unique LabelSet. A MetricFamily SHOULD have a name, Help, Type, and Unit metadata.
152152

153153
##### Name
154154

0 commit comments

Comments
 (0)