Update netstat_freebsd.go

Author: Rin0913

collector/netstat_freebsd.go

@@ -3,7 +3,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//     http://www.apache.org/licenses/LICENSE-2.0
+// http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ -127,71 +127,81 @@ func getData(queryString string) ([]byte, error) {
 
 func (c *netStatCollector) Update(ch chan<- prometheus.Metric) error {
 	tcpData, err := getData("net.inet.tcp.stats")
-	if err == nil && len(tcpData) >= int(unsafe.Sizeof(C.struct_tcpstat{})) {
-		tcpStats := *(*C.struct_tcpstat)(unsafe.Pointer(&tcpData[0]))
-
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpSendPacketsTotal,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_sndtotal),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpRecvPacketsTotal,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_rcvtotal),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpConnectionAttempts,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_connattempt),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpConnectionAccepts,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_accepts),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpConnectionDrops,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_drops),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatTcpRetransmitPackets,
-			prometheus.CounterValue,
-			float64(tcpStats.tcps_sndrexmitpack),
-		)
+	if err != nil {
+		return fmt.Errorf("failed to get TCP stats: %w", err)
+	}
+	if len(tcpData) < int(unsafe.Sizeof(C.struct_tcpstat{})) {
+		return fmt.Errorf("TCP data size mismatch: got %d, want >= %d", len(tcpData), unsafe.Sizeof(C.struct_tcpstat{}))
 	}
 
+	tcpStats := *(*C.struct_tcpstat)(unsafe.Pointer(&tcpData[0]))
+
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpSendPacketsTotal,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_sndtotal),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpRecvPacketsTotal,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_rcvtotal),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpConnectionAttempts,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_connattempt),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpConnectionAccepts,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_accepts),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpConnectionDrops,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_drops),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatTcpRetransmitPackets,
+		prometheus.CounterValue,
+		float64(tcpStats.tcps_sndrexmitpack),
+	)
+
 	udpData, err := getData("net.inet.udp.stats")
-	if err == nil && len(udpData) >= int(unsafe.Sizeof(C.struct_udpstat{})) {
-		udpStats := *(*C.struct_udpstat)(unsafe.Pointer(&udpData[0]))
-
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatUdpSendPacketsTotal,
-			prometheus.CounterValue,
-			float64(udpStats.udps_opackets),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatUdpRecvPacketsTotal,
-			prometheus.CounterValue,
-			float64(udpStats.udps_ipackets),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatUdpHeaderDrops,
-			prometheus.CounterValue,
-			float64(udpStats.udps_hdrops),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatUdpBadChecksum,
-			prometheus.CounterValue,
-			float64(udpStats.udps_badsum),
-		)
-		ch <- prometheus.MustNewConstMetric(
-			bsdNetstatUdpNoPort,
-			prometheus.CounterValue,
-			float64(udpStats.udps_noport),
-		)
+	if err != nil {
+		return fmt.Errorf("failed to get UDP stats: %w", err)
+	}
+	if len(udpData) < int(unsafe.Sizeof(C.struct_udpstat{})) {
+		return fmt.Errorf("UDP data size mismatch: got %d, want >= %d", len(udpData), unsafe.Sizeof(C.struct_udpstat{}))
 	}
 
+	udpStats := *(*C.struct_udpstat)(unsafe.Pointer(&udpData[0]))
+
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatUdpSendPacketsTotal,
+		prometheus.CounterValue,
+		float64(udpStats.udps_opackets),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatUdpRecvPacketsTotal,
+		prometheus.CounterValue,
+		float64(udpStats.udps_ipackets),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatUdpHeaderDrops,
+		prometheus.CounterValue,
+		float64(udpStats.udps_hdrops),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatUdpBadChecksum,
+		prometheus.CounterValue,
+		float64(udpStats.udps_badsum),
+	)
+	ch <- prometheus.MustNewConstMetric(
+		bsdNetstatUdpNoPort,
+		prometheus.CounterValue,
+		float64(udpStats.udps_noport),
+	)
+
 	return nil
 }