Skip to content

Commit 0fddfd1

Browse files
authored
Cache metricsfamily help text (#3175)
Signed-off-by: Mark Knapp <[email protected]>
1 parent 07ee8ef commit 0fddfd1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

collector/textfile.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,16 @@ func (c *textFileCollector) Update(ch chan<- prometheus.Metric) error {
253253
}
254254
}
255255

256+
mfHelp := make(map[string]*string)
256257
for _, mf := range parsedFamilies {
257258
if mf.Help == nil {
259+
if help, ok := mfHelp[*mf.Name]; ok {
260+
mf.Help = help
261+
continue
262+
}
258263
help := fmt.Sprintf("Metric read from %s", strings.Join(metricsNamesToFiles[*mf.Name], ", "))
259264
mf.Help = &help
265+
mfHelp[*mf.Name] = &help
260266
}
261267
}
262268

0 commit comments

Comments
 (0)