diskstats: Simplify condition (#3290)

mrueg · web-flow · commit 8804ce1551d0 · 2025-03-31T12:47:22.000+02:00
As the comment says, this can be simplified now.

Signed-off-by: Manuel Rüger &lt;manuel@rueg.eu&gt;
diff --git a/collector/diskstats_linux.go b/collector/diskstats_linux.go
@@ -398,15 +398,9 @@ func getUdevDeviceProperties(major, minor uint32) (udevInfo, error) {
 
 		line = strings.TrimPrefix(line, udevDevicePropertyPrefix)
 
-		/* TODO: After we drop support for Go 1.17, the condition below can be simplified to:
-
 		if name, value, found := strings.Cut(line, "="); found {
 			info[name] = value
 		}
-		*/
-		if fields := strings.SplitN(line, "=", 2); len(fields) == 2 {
-			info[fields[0]] = fields[1]
-		}
 	}
 
 	return info, nil

Original file line number	Diff line number	Diff line change
`@@ -398,15 +398,9 @@ func getUdevDeviceProperties(major, minor uint32) (udevInfo, error) {`
`398`	`398`
`399`	`399`	`line = strings.TrimPrefix(line, udevDevicePropertyPrefix)`
`400`	`400`
`401`		`- /* TODO: After we drop support for Go 1.17, the condition below can be simplified to:`
`402`		`-`
`403`	`401`	`if name, value, found := strings.Cut(line, "="); found {`
`404`	`402`	`info[name] = value`
`405`	`403`	`}`
`406`		`- */`
`407`		`- if fields := strings.SplitN(line, "=", 2); len(fields) == 2 {`
`408`		`- info[fields[0]] = fields[1]`
`409`		`- }`
`410`	`404`	`}`
`411`	`405`
`412`	`406`	`return info, nil`