Add a missing name to the *testing.T argument. (#425)

nerdatmath · web-flow · commit 5bd706760fa8 · 2021-12-13T10:39:23.000+01:00
When using t.Run, the subtest must take a named *testing.T argument. Otherwise, inner calls to t.Error etc. are invoked on the outer test object, which is pretty much always wrong.

Signed-off-by: Matt Harden &lt;matt.harden@gmail.com&gt;
diff --git a/proc_psi_test.go b/proc_psi_test.go
@@ -19,7 +19,7 @@ import (
 )
 
 func TestPSIStats(t *testing.T) {
-	t.Run("fake", func(*testing.T) {
+	t.Run("fake", func(t *testing.T) {
 		stats, err := getProcFixtures(t).PSIStatsForResource("fake")
 		if err == nil {
 			t.Fatal("fake resource does not have PSI statistics")

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ import (`
`19`	`19`	`)`
`20`	`20`
`21`	`21`	`func TestPSIStats(t *testing.T) {`
`22`		`- t.Run("fake", func(*testing.T) {`
	`22`	`+ t.Run("fake", func(t *testing.T) {`
`23`	`23`	`stats, err := getProcFixtures(t).PSIStatsForResource("fake")`
`24`	`24`	`if err == nil {`
`25`	`25`	`t.Fatal("fake resource does not have PSI statistics")`