fix(fmodata): improve listField validation to handle undefined items

This commit updates the listField function to use a more efficient check for non-string items in the input array. It also adds a test case to ensure that undefined list items are correctly rejected without throwing an error when no itemValidator is provided, enhancing input validation and error handling.

Author: eluce2

packages/fmodata/src/orm/field-builders.ts

@@ -313,8 +313,8 @@ export function listField<TItem = string, TAllowNull extends boolean = false>(
         }
 
         if (!itemValidator) {
-          const nonStringItem = input.find((item) => typeof item !== "string");
-          if (nonStringItem !== undefined) {
+          const hasNonStringItem = input.some((item) => typeof item !== "string");
+          if (hasNonStringItem) {
             return { issues: [issue("Expected all list items to be strings without an itemValidator")] };
           }
           const serialized = input.map((item) => normalizeFileMakerNewlines(item)).join(FILEMAKER_LIST_DELIMITER);

packages/fmodata/tests/orm-api.test.ts

@@ -109,6 +109,20 @@ describe("ORM API", () => {
       const writeResult = await config.inputValidator?.["~standard"].validate([1, 2, 3]);
       expect(writeResult).toEqual({ value: "1\r2\r3" });
     });
+
+    it("should reject undefined list items without throwing when no itemValidator is provided", async () => {
+      const field = listField();
+      const config = field._getConfig();
+
+      const writeResult = await config.inputValidator?.["~standard"].validate([
+        "A",
+        undefined,
+        "C",
+      ] as unknown as string[]);
+      expect(writeResult).toEqual({
+        issues: [{ message: "Expected all list items to be strings without an itemValidator" }],
+      });
+    });
   });
 
   describe("Table Definition", () => {