Skip to content

Conversation

@eluce2
Copy link
Collaborator

@eluce2 eluce2 commented Jan 5, 2026

Fixes TypeScript build errors in @proofkit/better-auth by updating type imports and adapter option parsing to be resilient to upstream changes.

The build was failing due to several TypeScript errors in @proofkit/better-auth related to type mismatches and missing exports from the better-auth dependency. These changes address those issues by:

  • Replacing direct imports of potentially volatile types (AdapterDebugLogs, BetterAuthDbSchema) with stable local definitions.
  • Implementing a more robust way to extract adapter configuration from adapter.options to handle variations in the better-auth package's internal structure.
  • Normalizing field types in src/migrate.ts to correctly handle array-based types from better-auth.
    This ensures the @proofkit/better-auth package builds successfully with the current better-auth dependency.

Open in Cursor Open in Web


Note

Improves resilience of migration type handling to upstream Better Auth changes.

  • Adds normalizeBetterAuthFieldType and updates field-to-FM type mapping in migrate.ts to support string/array union types via includes() checks
  • Adds patch changeset for @proofkit/better-auth

Written by Cursor Bugbot for commit a3dcb04. This will update automatically on new commits. Configure here.

This commit refactors how FileMaker adapter configurations are accessed, making it more robust. It also updates various dependencies, including rolldown and its related packages, to their latest versions.

Co-authored-by: eric.luce <[email protected]>
@cursor
Copy link

cursor bot commented Jan 5, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
proofkit-docs Ready Ready Preview Jan 12, 2026 4:19pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 5, 2026

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@88

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@88

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@88

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@88

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@88

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@88

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@88

commit: 8001249

Copy link
Collaborator Author

eluce2 commented Jan 5, 2026

@cursor add a changeset for this update

@cursor
Copy link

cursor bot commented Jan 5, 2026

Added. I’ll include a changeset for @proofkit/better-auth documenting the build/type-compatibility fix (resilient parsing of adapter options + normalized schema field typing) so it gets versioned/published correctly in this PR.


Open in Cursor Open in Web

Learn more about Cursor Agents

@eluce2 eluce2 marked this pull request as ready for review January 5, 2026 20:37
Handles array types like ["boolean", "null"] → "boolean|null"

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use DBAdapterDebugLogOption/DBFieldAttribute from better-auth
- Use filemakerConfig property instead of helper function
- Keep normalizeBetterAuthFieldType for array type handling

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@eluce2 eluce2 merged commit 2858f6a into main Jan 12, 2026
9 of 11 checks passed
@eluce2 eluce2 deleted the cursor/better-auth-type-errors-d272 branch January 12, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants