test fixes, add test composer.json files

Leonardo-Atalla · Leonardo-Atalla · commit 5407ebd4c8c6 · 2024-02-15T17:24:18.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,14 +16,18 @@ jobs:
             matrix:
                 php-version: [ '7.4', '8.2' ]
                 db-type: [ sqlite, mysql, pgsql, agnostic ]
-                symfony-version: [ '4-min', '4-max', '5-min', '5-max', '6-min', '6-max' ]
+                symfony-version: [ '4-min', '4-max', '5-min', '5-max', '6-min', '6-max', '7-min', '7-max']
                 exclude:
                   - symfony-version: '4-min'
                     php-version: '8.2'
                   - symfony-version: '6-min'
                     php-version: '7.4'
                   - symfony-version: '6-max'
                     php-version: '7.4'
+                  - symfony-version: '7-min'
+                    php-version: '7.4'
+                  - symfony-version: '7-max'
+                    php-version: '7.4'
         env:
             DB_NAME: 'propel_tests'
             DB_USER: 'propel'
@@ -125,6 +129,8 @@ jobs:
                   else
                     vendor/bin/phpunit -c tests/${{ matrix.db-type }}.phpunit.xml
                   fi
+              env:
+                SYMFONY_VERSION: ${{ matrix.symfony-version }}
 
             - name: Code Coverage Report
               if: success() && matrix.php-version == '7.4' && matrix.symfony-version == '5-max'
@@ -166,6 +172,8 @@ jobs:
               run: composer install --prefer-dist --no-interaction
 
             - name: PHPStan
+              env:
+                PHPSTAN: 1
               run: composer stan
 
             - name: Psalm
diff --git a/src/Propel/Generator/Command/MigrationUpCommand.php b/src/Propel/Generator/Command/MigrationUpCommand.php
@@ -44,7 +44,7 @@ protected function configure()
      *
      * @throws \Propel\Runtime\Exception\RuntimeException
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $configOptions = [];
 
diff --git a/src/Propel/Runtime/Validator/Constraints/Date.php b/src/Propel/Runtime/Validator/Constraints/Date.php
@@ -12,11 +12,6 @@
 
 class Date extends SymfonyDateConstraint
 {
-    /**
-     * @var string
-     */
-    public $message = 'This value is not a valid date.';
-
     /**
      * @var string
      */
diff --git a/tests/Propel/Tests/Common/Config/Loader/FileLoaderTest.php b/tests/Propel/Tests/Common/Config/Loader/FileLoaderTest.php
@@ -362,18 +362,14 @@ public function testCallResolveParamTwiceReturnsEmpty()
 
 class TestableFileLoader extends BaseFileLoader
 {
-    /**
-     * @return void
-     */
-    public function load($resource, $type = null)
+    public function load($resource, $type = null): ?array
     {
+        return null;
     }
 
-    /**
-     * @return void
-     */
-    public function supports($resource, $type = null)
+    public function supports($resource, $type = null): bool
     {
+        return false;
     }
 
     /**
diff --git a/tests/Propel/Tests/Runtime/Connection/PropelPDOTest.php b/tests/Propel/Tests/Runtime/Connection/PropelPDOTest.php
@@ -564,7 +564,7 @@ class LastMessageHandler extends AbstractHandler
      *
      * @return bool
      */
-    public function handle(array $record): bool
+    public function handle($record): bool
     {
         $this->latestMessage = (string)$record['message'];
 
diff --git a/tests/composer/composer-symfony7-max.json b/tests/composer/composer-symfony7-max.json
@@ -0,0 +1,66 @@
+{
+    "name": "propel/propel",
+    "type": "library",
+    "description": "Propel2 is an open-source Object-Relational Mapping (ORM) for PHP 5.5 and up.",
+    "keywords": [
+        "ORM",
+        "persistence",
+        "Active Record"
+    ],
+    "homepage": "http://www.propelorm.org/",
+    "license": "MIT",
+    "authors": [
+        {
+            "name": "William Durand",
+            "email": "william.durand1@gmail.com"
+        }
+    ],
+    "require": {
+        "php": ">=8.2",
+        "symfony/yaml": "^7.0.0",
+        "symfony/config": "^7.0.0",
+        "symfony/console": "^7.0.0",
+        "symfony/filesystem": "^7.0.0",
+        "symfony/finder": "^7.0.0",
+        "symfony/translation": "^7.0.0",
+        "symfony/validator": "^7.0.0",
+        "psr/log": "^1.0 || ^2.0 || ^3.0"
+    },
+    "require-dev": {
+        "ext-pdo": "*",
+        "ext-json": "*",
+        "ext-xml": "*",
+        "monolog/monolog": "^1.3 || ^2.3 || ^3.0",
+        "phpstan/phpstan": "^1.2",
+        "phpunit/phpunit": "^9.5.0",
+        "spryker/code-sniffer": "^0.17.2",
+        "psalm/phar": "^4.23",
+        "mikey179/vfsstream": "^1.6"
+    },
+    "suggest": {
+        "monolog/monolog": "The recommended logging library to use with Propel."
+    },
+    "autoload": {
+        "psr-4": {
+            "Propel\\": "src/Propel/"
+        }
+    },
+    "bin": [
+        "bin/propel"
+    ],
+    "scripts": {
+        "stan": [
+            "vendor/bin/phpstan analyze -l 1 -c tests/phpstan.neon src/"
+        ]
+    },
+    "extra": {
+        "branch-alias": {
+            "dev-master": "2.0-dev"
+        }
+    },
+    "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
+    }
+}
diff --git a/tests/composer/composer-symfony7-min.json b/tests/composer/composer-symfony7-min.json
@@ -0,0 +1,66 @@
+{
+    "name": "propel/propel",
+    "type": "library",
+    "description": "Propel2 is an open-source Object-Relational Mapping (ORM) for PHP 5.5 and up.",
+    "keywords": [
+        "ORM",
+        "persistence",
+        "Active Record"
+    ],
+    "homepage": "http://www.propelorm.org/",
+    "license": "MIT",
+    "authors": [
+        {
+            "name": "William Durand",
+            "email": "william.durand1@gmail.com"
+        }
+    ],
+    "require": {
+        "php": ">=8.2",
+        "symfony/yaml": "~7.0.0",
+        "symfony/config": "~7.0.0",
+        "symfony/console": "~7.0.0",
+        "symfony/filesystem": "~7.0.0",
+        "symfony/finder": "~7.0.0",
+        "symfony/translation": "~7.0.0",
+        "symfony/validator": "~7.0.0",
+        "psr/log": "^1.0 || ^2.0 || ^3.0"
+    },
+    "require-dev": {
+        "ext-pdo": "*",
+        "ext-json": "*",
+        "ext-xml": "*",
+        "monolog/monolog": "^1.3 || ^2.3 || ^3.0",
+        "phpstan/phpstan": "^1.2",
+        "phpunit/phpunit": "^9.5.0",
+        "spryker/code-sniffer": "^0.17.2",
+        "psalm/phar": "^4.23",
+        "mikey179/vfsstream": "^1.6"
+    },
+    "suggest": {
+        "monolog/monolog": "The recommended logging library to use with Propel."
+    },
+    "autoload": {
+        "psr-4": {
+            "Propel\\": "src/Propel/"
+        }
+    },
+    "bin": [
+        "bin/propel"
+    ],
+    "scripts": {
+        "stan": [
+            "vendor/bin/phpstan analyze -l 1 -c tests/phpstan.neon src/"
+        ]
+    },
+    "extra": {
+        "branch-alias": {
+            "dev-master": "2.0-dev"
+        }
+    },
+    "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ protected function configure()`
`44`	`44`	`*`
`45`	`45`	`* @throws \Propel\Runtime\Exception\RuntimeException`
`46`	`46`	`*/`
`47`		`- protected function execute(InputInterface $input, OutputInterface $output)`
	`47`	`+ protected function execute(InputInterface $input, OutputInterface $output): int`
`48`	`48`	`{`
`49`	`49`	`$configOptions = [];`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -362,18 +362,14 @@ public function testCallResolveParamTwiceReturnsEmpty()`
`362`	`362`
`363`	`363`	`class TestableFileLoader extends BaseFileLoader`
`364`	`364`	`{`
`365`		`- /**`
`366`		`- * @return void`
`367`		`- */`
`368`		`- public function load($resource, $type = null)`
	`365`	`+ public function load($resource, $type = null): ?array`
`369`	`366`	`{`
	`367`	`+ return null;`
`370`	`368`	`}`
`371`	`369`
`372`		`- /**`
`373`		`- * @return void`
`374`		`- */`
`375`		`- public function supports($resource, $type = null)`
	`370`	`+ public function supports($resource, $type = null): bool`
`376`	`371`	`{`
	`372`	`+ return false;`
`377`	`373`	`}`
`378`	`374`
`379`	`375`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -564,7 +564,7 @@ class LastMessageHandler extends AbstractHandler`
`564`	`564`	`*`
`565`	`565`	`* @return bool`
`566`	`566`	`*/`
`567`		`- public function handle(array $record): bool`
	`567`	`+ public function handle($record): bool`
`568`	`568`	`{`
`569`	`569`	`$this->latestMessage = (string)$record['message'];`
`570`	`570`