Better log output.

Author: dereuromark

src/Propel/Generator/Manager/ReverseManager.php

@@ -215,17 +215,17 @@ protected function buildModel()
         $nbTables = $parser->parse($database);
 
         $excludeTables = $config->getConfigProperty('exclude_tables');
-        $tables = [];
+        $tableNames = [];
 
         foreach ($database->getTables() as $table) {
             $skip = false;
-            $tablename = $table->getName();
+            $tableName = $table->getName();
 
-            if (in_array($tablename, $excludeTables, true)) {
+            if (in_array($tableName, $excludeTables, true)) {
                 $skip = true;
             } else {
                 foreach ($excludeTables as $excludeTable) {
-                    if (preg_match('/^' . str_replace('*', '.*', $excludeTable) . '$/', $tablename)) {
+                    if (preg_match('/^' . str_replace('*', '.*', $excludeTable) . '$/', $tableName)) {
                         $skip = true;
                         break;
                     }
@@ -236,10 +236,14 @@ protected function buildModel()
                 continue;
             }
 
+            $tableNames[] = $table;
+
             $database->removeTable($table);
         }
 
-        $this->log(sprintf('Successfully reverse engineered %d tables', $nbTables));
+        if ($tableNames) {
+            $this->log(sprintf('Successfully reverse engineered %d/%d tables (%s)', count($tableNames), $nbTables, implode(', ', $tableNames)));
+        }
 
         return $database;
     }

tests/Propel/Tests/Generator/Command/DatabaseReverseTest.php

@@ -2,6 +2,7 @@
 
 namespace Propel\Tests\Generator\Command;
 
+use Propel\Generator\Command\AbstractCommand;
 use Propel\Generator\Command\DatabaseReverseCommand;
 use Propel\Runtime\Propel;
 use Propel\Tests\TestCaseFixturesDatabase;
@@ -38,11 +39,11 @@ public function testCommandWithoutNamespace()
 
         chdir($currentDir);
 
-        if (0 !== $result) {
+        if (AbstractCommand::CODE_SUCCESS !== $result) {
             rewind($output->getStream());
             echo stream_get_contents($output->getStream());
         }
-        $this->assertEquals(0, $result, 'database:reverse tests exited successfully');
+        $this->assertSame(AbstractCommand::CODE_SUCCESS, $result, 'database:reverse tests exited successfully');
 
         $databaseXml = simplexml_load_file($outputDir . '/schema.xml');
         $this->assertEquals('reverse-test', $databaseXml['name']);