Non-static method Propel\Runtime\ActiveQuery\ModelCriteria::delete()` cannot be called statically

[phpfui]

Getting the following error from the code generated by propel init:

Fatal error: Uncaught Error: Non-static method Propel\Runtime\ActiveQuery\ModelCriteria::delete()` cannot be called statically in C:\websites\php-orm-sql-benchmarks\SOB\Propel2\Base\EmployeeQuery.php on line 222

Indeed, ModelCriteria::delete is not static.

Running PHP 8.2.13 (but this is not a PHP issue, PHP is reported the error correctly)

Composer:

"propel/propel": "2.0.0-beta4",

The generated method in question:

	public function delete(?ConnectionInterface $con = null) : int
	{
		if (null === $con) {
			$con = Propel::getServiceContainer()->getWriteConnection(EmployeeTableMap::DATABASE_NAME);
		}

		$criteria = $this;

		// Set the correct dbName
		$criteria->setDbName(EmployeeTableMap::DATABASE_NAME);

		// use transaction because $criteria could contain info
		// for more than one table or we could emulating ON DELETE CASCADE, etc.
		return $con->transaction(static function() use ($con, $criteria) {
			$affectedRows = 0; // initialize var to track total num of affected rows

			EmployeeTableMap::removeInstanceFromPool($criteria);

			$affectedRows += ModelCriteria::delete($con);  // this is line 222
			EmployeeTableMap::clearRelatedInstancePool();

			return $affectedRows;
		});
	}

[rizwanjiwan]

Hey, I tired reproducing this in my project (php 8.3.6). Seems to work fine. Since the generated Query base classes inherit from ModelCriteria, ModelCriteria::delete($con) reads to me to be equivalent to parent::delete($con): http://php.adamharvey.name/manual/en/keyword.parent.php

It's not recommended, but still valid PHP.

I'm doing this on my end (on my implementation of an employee model): EmployeeQuery::create()->filterById(2)->delete()

I'm happy to try and help if you let me know if you see it differently or have more information.

[phpfui]

So it looks like it should be parent::delete($con) and not ModelCriteria::delete($con).

I think this changed in a recent version of PHP. Because ModelCriteria::delete does not reference $this, it must be static. parent::delete has an implicit $this, so it calls the parent method, which is not static. That should work, but I don't know the code, which is why I asked.

This makes sense to me now. Looks like this changed in PHP 8.0. https://php.watch/versions/8.0/non-static-static-call-fatal-error

This would explain why it worked in the past but does not work now. Not sure why you can't reproduce. Maybe I generated things wrong?

[smhg]

@phpfui I would be very interested to see your Propel2 code in https://github.com/phpfui/php-orm-sql-benchmarks. Would you be able to make it available somewhere?

Something like $employee->delete() works fine as parent::delete and ModelCriteria::delete are the same inside query classes that extend from ModelCriteria (see this comment).

How are you calling ->delete()?

[phpfui]

Thanks for your interest and any insights. I have updated the repo. I think I generated things correctly, but I don't know Propel. I had hoped to use it for my projects, as it fit my mental model, but was unable to make it work.

[smhg]

Thanks!
How are you installing Propel? It's not listed in composer.json.

[phpfui]

Hmm, I probably removed it at some point. Please add and fix up the Propel stuff and submit a PR. I have not done much with this for a while, but I do believe it is probably one of the better basic PHP ORM SQL benchmarks out there and I am committed to continue to maintain it.

All help appreciated!

[phpfui]

smhg where you able to figure out why ModelCriteria::delete is not working for me? Is my generated code wrong?

[smhg]

@phpfui sorry, I don't have the capacity to contribute.

As related to the original issue: I can't figure out in what scenario the error would occur.
While it would make sense to apply #2016, this doesn't seem to be connected.
In light of the lack of reproducibility I'm suggesting we close this issue.

[phpfui]

I used dev-master and regenerated everything with "propel init" and still have the same issue. Looks like a bug in the generated code, or the library itself.

I was already calling parent:: (it was generated that way), but thanks for looking into it.

And it is very reproducible. Clone the phpfui/php-orm-sql-benchmarks repo. Add propel/propel to composer.json, copy inProgress/Propel2 to SOB directory, run php benchmark.php. The Propel2 tests will fail on delete.

Actually I just pushed a Propel2 branch with all the other ORMs removed. Just get the branch, composer update, then "php benchmark.php" and BOOM! I may be doing something wrong, but this is generated code and I suspect a bug in the library. Do with it what you wish. Just a heads up.

[PhilinTv]

Beta5 Justification:
Confusion from code generation. Switching to parent::delete() is backward-compatible and resolves PHP 8+ incompat.

[phpfui]

I found the problem! This is in the SOB\Propel2\Base\EmployeeQuery.php which was automatically generated.

// use transaction because $criteria could contain info
// for more than one table or we could emulating ON DELETE CASCADE, etc.
return $con->transaction(static function() use ($con, $criteria) {
	$affectedRows = 0; // initialize var to track total num of affected rows
	EmployeeTableMap::removeInstanceFromPool($criteria);
	$affectedRows += parent::delete($con); // This line is causing the error!
	EmployeeTableMap::clearRelatedInstancePool();
	return $affectedRows;
});

The basic problem here is you are using a static function, but that means it is not in the scope of the class. The solution is to remove the static function and use a normal function which is in the scope of the class.

Corrected code:

return $con->transaction(function() use ($con, $criteria) {

I would be happy to submit a PR for this, but no clue where to look to fix this.

[smhg]

@phpfui there doesn't seem to be any code that generates a static closure in Propel2.
Specifically, that line in delete() for query classes can be found here. It wasn't changed in 11 years.

You mention a Propel2 branch in phpfui/php-orm-sql-benchmarks, but I can't find that either.

Am I looking at the wrong things?