Skip to content

Conversation

@mringler
Copy link
Contributor

@smhg
Copy link
Contributor

smhg commented Apr 30, 2025

@mringler would you be able to push a rebase?
I know it is a trivial change, but there should then remain one unique index being added.
Do you remember why you added that one? As tests run without it.

@mringler
Copy link
Contributor Author

Hey Sam,
those are basically the same schema. Not sure if the schemas/schema.xml one is even used, but as long as it is not removed, I thought it's best to keep it valid.

This is the fix from perpl, but I think by now there are two (or three?) other PRs that change only the first schema - I am happy to close this PR in favor of those. Let me know!
Best,
Moritz

@smhg
Copy link
Contributor

smhg commented Apr 30, 2025

@mringler You won't believe it, but those other PR's are merged/closed! 🚀

This PR sounds like a fix still so I'd suggest to merge it. If it is not used, the schema can be deleted at a later point. But I'll let you decide: feel free to either rebase or close the PR.

@smhg
Copy link
Contributor

smhg commented Apr 30, 2025

Sorry, I just noticed the other schema was already included in #2034. So feel free to close this. Thanks!

@mringler mringler closed this Apr 30, 2025
@mringler mringler deleted the fix_tests/add_unique_index_for_complex_fks branch October 30, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants