[Fix] Passage reward function (#168)

* Fix: correct joint passage reward function (issue #145)

* fix

---------

Co-authored-by: Matteo Bettini <[email protected]>

Author: Benabdellah22

vmas/scenarios/joint_passage.py

@@ -458,11 +458,10 @@ def reward(self, agent: Agent):
                             self.world.get_distance(a, passage)
                             <= self.min_collision_distance
                         ] += self.collision_reward
-                    for wall in self.walls:
-                        self.collision_rew[
-                            self.world.get_distance(a, wall)
-                            <= self.min_collision_distance
-                        ] += self.collision_reward
+                for wall in self.walls:
+                    self.collision_rew[
+                        self.world.get_distance(a, wall) <= self.min_collision_distance
+                    ] += self.collision_reward
 
             # Joint collisions
             for p in self.passages:

vmas/scenarios/joint_passage_size.py

@@ -1,4 +1,4 @@
-#  Copyright (c) 2022-2024.
+#  Copyright (c) 2022-2025.
 #  ProrokLab (https://www.proroklab.org/)
 #  All rights reserved.
 import math
@@ -453,11 +453,10 @@ def reward(self, agent: Agent):
                                 self.world.get_distance(a, passage)
                                 <= self.min_collision_distance
                             ] += self.collision_reward
-                    for wall in self.walls:
-                        self.collision_rew[
-                            self.world.get_distance(a, wall)
-                            <= self.min_collision_distance
-                        ] += self.collision_reward
+                for wall in self.walls:
+                    self.collision_rew[
+                        self.world.get_distance(a, wall) <= self.min_collision_distance
+                    ] += self.collision_reward
 
             # Energy reward
             if self.energy_reward_coeff != 0: