Skip to content

Commit 83212ef

Browse files
committed
Fix: correct joint-passage reward function (issue #145)
1 parent 0618cbf commit 83212ef

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

vmas/scenarios/joint_passage.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def make_world(self, batch_dim: int, device: torch.device, **kwargs):
7373
device,
7474
x_semidim=1,
7575
y_semidim=1,
76-
substeps=7 if not self.asym_package else 10,
76+
substeps=2, # 7 if not self.asym_package else 10,
7777
joint_force=900 if self.asym_package else 400,
7878
collision_force=2500 if self.asym_package else 1500,
7979
drag=0.25 if not self.asym_package else 0.15,
@@ -460,8 +460,7 @@ def reward(self, agent: Agent):
460460
] += self.collision_reward
461461
for wall in self.walls:
462462
self.collision_rew[
463-
self.world.get_distance(a, wall)
464-
<= self.min_collision_distance
463+
self.world.get_distance(a, wall) <= self.min_collision_distance
465464
] += self.collision_reward
466465

467466
# Joint collisions

0 commit comments

Comments
 (0)