Merge pull request #6 from prosegrinder/constants

Added Constants

Author: davidlday

.travis.yml

@@ -1,7 +1,8 @@
+dist: xenial
 language: python
 python:
-- pypy3
-- pypy
+- 'pypy3.5'
+- '3.7'
 - '3.6'
 - '3.5'
 - '3.4'
@@ -10,15 +11,16 @@ sudo: false
 install:
 - pip install -U pip
 - pip install -U pytest
-script:
+- pip install -U twine
 - python ./setup.py develop
-- pytest tests/*
+script:
+- pytest ./tests/
 deploy:
   provider: pypi
   user: davidlday
   password:
     secure: Sqbs5JjSDlgfhfDjqBUQibtFkonfOr7WOIXRcGywclcb/BoblK2i6y5TMZE4Le0aMwtmWZ72CruIJu31H010HzVi2LuH+l6MiDdkDJW5J54ctnCXi9jysvp2iHt7EXsFMG5tMwbc0fQtnPGskaBq7WFt/NMkPyFfodIJa/OAWaMDPCLXaultDzcLCGCVD9EAJCz49cEJeYCGPBY5bCwwsq95OmM/71snJNoWwIhsl8x9wydsTEqESNokrSXzk52+YJ1eWmIP8dFn7mcHroveAEaV7raHprNDTskBLvkfDYiaqvjOb+VHYk/HxHvJOAqDdBvJSzhA18PjmFkfdxveV/BehbvGzBCrQU4hNNP9HdPFyx0wU2xkPeEC6BlSqzYpx/esvAcFJYFEeGZlX8ciDIaCYynRe40EbeQQgI4QSiisMsZ0PyBzOCJ271yoxzrqYlTrlsEkTfp9o1x9HX6hQwRPjMoIVnBHB8jKginkPjXLuxythOQ14/1+D11He6HHrFiYVQ2TSJwA/bOuuJVolrXWwwM52LB7JjoF9jr79V+/804ZzfWehVBChmaDl+hZLxqcJ7LExHhvCKB08p8yRZeWdtttBsxQMCa+7NAVwiZSOTSg4jnqlMKLR9be3eblGkeQkWFNOpbA1LP89amIixhi91zBY7bEP6HOXlMR2gg=
   distributions: sdist bdist_wheel
   on:
-    python: '3.6'
+    python: '3.7'
     tags: true

pointofview/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

pointofview/__init__.py

@@ -10,6 +10,12 @@
 __version__ = pkg_resources.resource_string(
     'pointofview', 'VERSION').decode('utf-8').strip()
 
+# Constants for use in comparisons
+FIRST = 'first'
+SECOND = 'second'
+THIRD = 'third'
+NONE = None
+
 # NOTE:
 # Words are expected to be in lower case.
 #
@@ -18,13 +24,13 @@
 # Second person PoV can also contain third person words.
 # Third person PoV can only contain third person words.
 POV_WORDS = OrderedDict([
-    ('first',
+    (FIRST,
         ["i", "i'm", "i'll", "i'd", "i've", "me", "mine", "myself", "we",
             "we're", "we'll", "we'd", "we've", "us", "ours", "ourselves"]),
-    ('second',
+    (SECOND,
         ["you", "you're", "you'll", "you'd", "you've",
             "your", "yours", "yourself", "yourselves"]),
-    ('third',
+    (THIRD,
         ["he", "he's", "he'll", "he'd", "him", "his", "himself", "she", "she's",
             "she'll", "she'd", "her", "hers", "herself", "it", "it's", "it'll",
             "it'd", "itself", "they", "they're", "they'll", "they'd", "they've",

tests/test_pointofview.py

@@ -32,14 +32,14 @@
 # https://docs.pytest.org/en/latest/index.html
 
 def test_first():
-    assert(pointofview.get_text_pov(POV_FIRST_SINGULAR) == 'first')  # nosec
-    assert(pointofview.get_text_pov(POV_FIRST_PLURAL) == 'first')    # nosec
+    assert(pointofview.get_text_pov(POV_FIRST_SINGULAR) == pointofview.FIRST)  # nosec
+    assert(pointofview.get_text_pov(POV_FIRST_PLURAL) == pointofview.FIRST)    # nosec
 
 def test_second():
-    assert(pointofview.get_text_pov(POV_SECOND) == 'second')         # nosec
+    assert(pointofview.get_text_pov(POV_SECOND) == pointofview.SECOND)         # nosec
 
 def test_third():
-    assert(pointofview.get_text_pov(POV_THIRD) == 'third')           # nosec
+    assert(pointofview.get_text_pov(POV_THIRD) == pointofview.THIRD)           # nosec
 
 def test_none():
-    assert(pointofview.get_text_pov(POV_NONE) == None)               # nosec
+    assert(pointofview.get_text_pov(POV_NONE) == pointofview.NONE)               # nosec