Implemented constants for POVs.

Author: davidlday

pointofview/__init__.py

@@ -10,6 +10,12 @@
 __version__ = pkg_resources.resource_string(
     'pointofview', 'VERSION').decode('utf-8').strip()
 
+# Constants for use in comparisons
+FIRST = 'first'
+SECOND = 'second'
+THIRD = 'third'
+NONE = None
+
 # NOTE:
 # Words are expected to be in lower case.
 #
@@ -18,13 +24,13 @@
 # Second person PoV can also contain third person words.
 # Third person PoV can only contain third person words.
 POV_WORDS = OrderedDict([
-    ('first',
+    (FIRST,
         ["i", "i'm", "i'll", "i'd", "i've", "me", "mine", "myself", "we",
             "we're", "we'll", "we'd", "we've", "us", "ours", "ourselves"]),
-    ('second',
+    (SECOND,
         ["you", "you're", "you'll", "you'd", "you've",
             "your", "yours", "yourself", "yourselves"]),
-    ('third',
+    (THIRD,
         ["he", "he's", "he'll", "he'd", "him", "his", "himself", "she", "she's",
             "she'll", "she'd", "her", "hers", "herself", "it", "it's", "it'll",
             "it'd", "itself", "they", "they're", "they'll", "they'd", "they've",

tests/test_pointofview.py

@@ -32,14 +32,14 @@
 # https://docs.pytest.org/en/latest/index.html
 
 def test_first():
-    assert(pointofview.get_text_pov(POV_FIRST_SINGULAR) == 'first')  # nosec
-    assert(pointofview.get_text_pov(POV_FIRST_PLURAL) == 'first')    # nosec
+    assert(pointofview.get_text_pov(POV_FIRST_SINGULAR) == pointofview.FIRST)  # nosec
+    assert(pointofview.get_text_pov(POV_FIRST_PLURAL) == pointofview.FIRST)    # nosec
 
 def test_second():
-    assert(pointofview.get_text_pov(POV_SECOND) == 'second')         # nosec
+    assert(pointofview.get_text_pov(POV_SECOND) == pointofview.SECOND)         # nosec
 
 def test_third():
-    assert(pointofview.get_text_pov(POV_THIRD) == 'third')           # nosec
+    assert(pointofview.get_text_pov(POV_THIRD) == pointofview.THIRD)           # nosec
 
 def test_none():
-    assert(pointofview.get_text_pov(POV_NONE) == None)               # nosec
+    assert(pointofview.get_text_pov(POV_NONE) == pointofview.NONE)               # nosec