How to use embark and denote-open-or-create to jump to a file in dired?

[brabalan]

I wanted to reveal a file that I had searched for using denote-open-or-create, so while it was selected (in vertico), I invoked embark and the jump action j. The problem is that it calls dired-jump with a file name that is relative to denote-directory, so it fails if the current directory is not that one. For instance, I am in some teaching directory and I want to open a note that is in a notes subdirectory of my denote-directory. But in this trace the denote-directory is not taken into account at all.

Debugger entered--Lisp error: (file-missing "Setting current directory" "No such file or directory" "~/work/teaching/notes/")
  call-process("/opt/homebrew/bin/gls" nil t nil "--dired" "-ahl" "--group-directories-first" "--" "/Users/schmitta/work/teaching/notes/")
  insert-directory("/Users/schmitta/work/teaching/notes/" "--dired -ahl --group-directories-first" nil t)
  dired-insert-directory("/Users/schmitta/work/teaching/notes/" "-ahl --group-directories-first" nil nil t)
  dired-readin-insert()
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_45>()
  combine-change-calls-1(1 1 #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_45>)
  dired-readin()
  dired-internal-noselect("~/work/teaching/notes/" nil)
  dired-noselect("/Users/schmitta/work/teaching/notes/" nil)
  dired("/Users/schmitta/work/teaching/notes/")
  dired-jump(nil "notes/20221007T135028--tags__denote_list.org")
  embark-dired-jump("notes/20221007T135028--tags__denote_list.org" nil)
  funcall-interactively(embark-dired-jump "notes/20221007T135028--tags__denote_list.org" nil)
  command-execute(embark-dired-jump)
  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_86>(:action embark-dired-jump :quit t :orig-type file :orig-target "notes/20221007T135028--tags__denote_list.org" :bounds nil :type file :target "notes/20221007T135028--tags__denote_list.org")
  embark--run-around-action-hooks(embark-dired-jump (:orig-type file :orig-target "notes/20221007T135028--tags__denote_list.org" :bounds nil :type file :target "notes/20221007T135028--tags__denote_list.org") t)

Is there a way to use embark with files listed with denote-open-or-create?

[protesilaos]

What is the actual filesystem path you have there? The error here suggests it gets the wrong path, so this might give us a clue as to how to proceed:

(file-missing "Setting current directory" "No such file or directory" "~/work/teaching/notes/")

[brabalan]

The path of the current directory when trying this was ~/work/teaching, as I was working on a file there. My denote directory is ~/Documents/Org/denote and the note I’m trying to open is in the notes sub-directory of the denote directory.

The trace seems to suggest the denote directory is ignored when searching for the file and the current working directory is used instead.

[protesilaos]

By the way, I tried what you did with Embark and it worked as expected.

[brabalan]

Does it work as well when you change your current directory to something unrelated to the denote one?

[protesilaos]

From: Alan Schmitt ***@***.***> Date: Wed, 15 Jan 2025 06:43:45 -0800 Does it work as well when you change your current directory to something unrelated to the denote one?

It works when I am using consult-denote-mode, but otherwise I get the problem you describe. Does this change fix the issue on your end? denote.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/denote.el b/denote.el index 02d3374..e3b1061 100644 --- a/denote.el +++ b/denote.el @@ -1430,7 +1430,8 @@ (defun denote-file-prompt (&optional files-matching-regexp prompt-text no-requir With optional NO-REQUIRE-MATCH, accept the given input as-is. Return the absolute path to the matching file." - (let* ((relative-files (mapcar #'denote-get-file-name-relative-to-denote-directory + (let* ((default-directory (denote-directory)) + (relative-files (mapcar #'denote-get-file-name-relative-to-denote-directory (denote-directory-files files-matching-regexp :omit-current))) (prompt (format "%s in %s: " (or prompt-text "Select FILE")

…

-- Protesilaos Stavrou https://protesilaos.com

[brabalan]

It works, thanks a lot! (And I really need to look at consult-denote…)

[protesilaos]

From: Alan Schmitt ***@***.***> Date: Thu, 16 Jan 2025 00:48:23 -0800 It works, thanks a lot! (And I really need to look at consult-denote…)

I pushed the change. Thank you!

…

-- Protesilaos Stavrou https://protesilaos.com