`denote-rename-file-keywords` with custom `crm-separator`

[mentalisttraceur]

I have crm-separator set to ,\n, but denote-rename-file-keywords inserts just , between candidates.

(No rush/need to fix this for me -- I wrote my own "Denoted" renaming functions long ago and I'm just gonna keep doing my own thing there -- but I figured you'd want the heads up of a real-world use-case that trips over this.)

[protesilaos]

For some reason I never got a notification about this issue, sorry!

At any rate, I notice that the crm-separator is a regexp. What would be the safest way for us to get the comma or whatever out of it?

Otherwise, yes, I think we should not hardcode the comma and just insert the resolved crm-separator.

[mentalisttraceur]

I think inserting crm-separator is almost a strict improvement over inserting ",". Almost all regexps would fail in both cases. The most conservative choice is to define a custom variable that's denote- specific, but really all CRM uses would benefit from one answer/solution here.

Ultimately upstream itself is wrongly (incompletely) designed here: crm ought to provide two variables -- one for the separator to insert and one for the regexp to match separators. I think if we can very confidently think of what that variable's name ought to be, we can start using it if it's defined. Like, personally, I think I would do (if (boundp 'crm-default-separator) crm-default-separator ","), and shoot a patch+explanation to the Emacs mailing list.