refactor: improve error logging

Author: saitunc

packages/sequencer/src/settlement/SettlementModule.ts

@@ -9,7 +9,15 @@ import {
   SettlementSmartContractBase,
   DynamicBlockProof,
 } from "@proto-kit/protocol";
-import { AccountUpdate, fetchAccount, Field, Mina, PublicKey, TokenContract, TokenId } from "o1js";
+import {
+  AccountUpdate,
+  fetchAccount,
+  Field,
+  Mina,
+  PublicKey,
+  TokenContract,
+  TokenId,
+} from "o1js";
 import { inject } from "tsyringe";
 import {
   EventEmitter,
@@ -351,53 +359,71 @@ export class SettlementModule
       ).bridgeContractMina(),
     };
   }
-  
+
   public async checkDeployment(
-  tokenBridges?: Array<{ address: PublicKey; tokenId: Field }>
-): Promise<void | never> {
-  const contractAddresses = this.getContractAddresses();
-  
-  if (this.baseLayer.config.network.type !== 'local') {
-    // Check main contracts
-    await Promise.all(
-      contractAddresses.map(async (pubKey) => {
-        const { account, error } = await fetchAccount({ publicKey: pubKey });
-        if (!account || !!error) {
-          throw new Error(`Error finding account ${pubKey.toBase58()}`);
-        }
-      })
-    );
-    
-    // Check token bridges with their tokenIds
-    if (tokenBridges) {
+    tokenBridges?: Array<{ address: PublicKey; tokenId: Field }>
+  ): Promise<void | never> {
+    const contractAddresses = this.getContractAddresses();
+
+    if (this.baseLayer.config.network.type !== "local") {
+      // Check main contracts
       await Promise.all(
-        tokenBridges.map(async ({ address, tokenId }) => {
-          const { account, error } = await fetchAccount({ 
-            publicKey: address, 
-            tokenId 
-          });
-          if (!account || !!error) {
-            throw new Error(`Error finding token bridge ${address.toBase58()} @ ${tokenId.toString()}`);
+        contractAddresses.map(async (pubKey) => {
+          const { account, error } = await fetchAccount({ publicKey: pubKey });
+
+          if (!account) {
+            let message = `Account ${pubKey.toBase58()} not found on chain`;
+
+            if (error !== undefined) {
+              message += `: ${error.statusText}`;
+            }
+
+            throw new Error(message);
           }
         })
       );
-    }
-  } else {
-    // Local network
-    contractAddresses.forEach((pubKey) => {
-      if (!Mina.hasAccount(pubKey)) {
-        throw new Error(`Contract ${pubKey.toBase58()} not found on local chain`);
+
+      // Check token bridges with their tokenIds
+      if (tokenBridges) {
+        await Promise.all(
+          tokenBridges.map(async ({ address, tokenId }) => {
+            const { account, error } = await fetchAccount({
+              publicKey: address,
+              tokenId,
+            });
+
+            if (!account) {
+              let message = `Account ${address.toBase58()} not found on chain`;
+
+              if (error !== undefined) {
+                message += `: ${error.statusText}`;
+              }
+
+              throw new Error(message);
+            }
+          })
+        );
       }
-    });
-    
-    // Check token bridges
-    if (tokenBridges) {
-      tokenBridges.forEach(({ address, tokenId }) => {
-        if (!Mina.hasAccount(address, tokenId)) {
-          throw new Error(`Token bridge ${address.toBase58()} @ ${tokenId.toString()} not found`);
+    } else {
+      // Local network
+      contractAddresses.forEach((pubKey) => {
+        if (!Mina.hasAccount(pubKey)) {
+          throw new Error(
+            `Contract ${pubKey.toBase58()} not found on local chain`
+          );
         }
       });
+
+      // Check token bridges
+      if (tokenBridges) {
+        tokenBridges.forEach(({ address, tokenId }) => {
+          if (!Mina.hasAccount(address, tokenId)) {
+            throw new Error(
+              `Token bridge ${address.toBase58()} @ ${tokenId.toString()} not found`
+            );
+          }
+        });
+      }
     }
   }
 }
-}