Added forceProverExists to protect against missing provers for non-sideloaded circuits

Author: rpanic

packages/common/src/compiling/CompileRegistry.ts

@@ -30,10 +30,24 @@ export class CompileRegistry {
 
   private artifacts: ArtifactRecord = {};
 
-  // TODO Add possibility to force recompilation for non-sideloaded dependencies
+  private inForceProverBlock = false;
+
+  /**
+   * This function forces compilation even if the artifact itself is in the registry.
+   * Basically the statement is: The artifact along is not enough, we need to
+   * actually have the prover compiled.
+   * This is true for non-sideloaded circuit dependencies.
+   */
+  public async forceProverExists(
+    f: (registry: CompileRegistry) => Promise<void>
+  ) {
+    this.inForceProverBlock = true;
+    await f(this);
+    this.inForceProverBlock = false;
+  }
 
   public async compile(target: CompileTarget) {
-    if (this.artifacts[target.name] === undefined) {
+    if (this.artifacts[target.name] === undefined || this.inForceProverBlock) {
       const artifact = await this.compiler.compileContract(target);
       this.artifacts[target.name] = artifact;
       return artifact;

packages/protocol/src/prover/block/BlockProver.ts

@@ -931,8 +931,10 @@ export class BlockProver
   public async compile(
     registry: CompileRegistry
   ): Promise<Record<string, CompileArtifact> | undefined> {
-    await this.stateTransitionProver.compile(registry);
-    await this.runtime.compile(registry);
+    await registry.forceProverExists(async () => {
+      await this.stateTransitionProver.compile(registry);
+      await this.runtime.compile(registry);
+    });
 
     return await this.zkProgrammable.compile(registry);
   }