Skip to content

Commit 8b3b4d2

Browse files
committed
Made some adaptations
1 parent 3417d03 commit 8b3b4d2

File tree

8 files changed

+33
-8
lines changed

8 files changed

+33
-8
lines changed

packages/api/src/metrics/OpenTelemetryServer.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ import { PrometheusExporter } from "@opentelemetry/exporter-prometheus";
1313
import { RuntimeNodeInstrumentation } from "@opentelemetry/instrumentation-runtime-node";
1414
import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-grpc";
1515
import { inject } from "tsyringe";
16-
import { DependencyFactory, DependencyRecord } from "@proto-kit/common";
16+
import { DependencyFactory, DependencyRecord, log } from "@proto-kit/common";
1717

1818
import { SequencerInstrumentation } from "./SequencerInstrumentation";
1919
import { OpenTelemetryTracer } from "./OpenTelemetryTracer";
20+
import { diag, DiagConsoleLogger, DiagLogLevel } from "@opentelemetry/api";
2021

2122
export type OpenTelemetryServerConfig = {
2223
metrics?: {
@@ -91,5 +92,10 @@ export class OpenTelemetryServer
9192
});
9293

9394
sdk.start();
95+
96+
// TODO Write logger to directly integrate with our logging library
97+
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.ERROR);
98+
99+
log.info("OpenTelemetryServer started");
94100
}
95101
}

packages/common/src/config/ModuleContainer.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,12 @@ export class ModuleContainer<
410410
!this.container.isRegistered(key) ||
411411
declaration.forceOverwrite === true
412412
) {
413+
if (this.container.isRegistered(key) && declaration.forceOverwrite) {
414+
log.warn(
415+
`You are trying to overwrite dependency ${key}, which is already registered. This is currently not supported. Try to define your dependency earlier.`
416+
);
417+
}
418+
413419
// Find correct provider type and call respective register
414420
if (isValueProvider(declaration)) {
415421
this.container.register(key, declaration);

packages/deployment/src/queue/InstantiatedBullQueue.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class InstantiatedBullQueue implements InstantiatedQueue {
2525
}
2626

2727
public async addTask(payload: TaskPayload): Promise<{ taskId: string }> {
28-
log.debug("Adding task: ", payload);
28+
log.trace("Adding task: ", payload);
2929
const job = await this.queue.add(this.name, payload, {
3030
attempts: this.options.retryAttempts ?? 2,
3131
});
@@ -37,7 +37,7 @@ export class InstantiatedBullQueue implements InstantiatedQueue {
3737
await this.events.waitUntilReady();
3838

3939
this.events.on("completed", async (result) => {
40-
log.debug("Completed task: ", result);
40+
log.trace("Completed task: ", result);
4141
try {
4242
await this.listeners.executeListeners(
4343
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions

packages/sequencer/src/protocol/production/sequencing/BlockProducerModule.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { inject } from "tsyringe";
2-
import { log } from "@proto-kit/common";
2+
import { injectOptional, log } from "@proto-kit/common";
33
import {
44
MethodIdResolver,
55
MethodParameterEncoder,
@@ -41,7 +41,8 @@ export class BlockProducerModule extends SequencerModule<BlockConfig> {
4141

4242
public constructor(
4343
@inject("Mempool") private readonly mempool: Mempool,
44-
private readonly messageService: IncomingMessagesService,
44+
@injectOptional("IncomingMessagesService")
45+
private readonly messageService: IncomingMessagesService | undefined,
4546
@inject("UnprovenStateService")
4647
private readonly unprovenStateService: AsyncStateService,
4748
@inject("UnprovenMerkleStore")
@@ -171,6 +172,8 @@ export class BlockProducerModule extends SequencerModule<BlockConfig> {
171172
return undefined;
172173
}
173174

175+
// TODO Move to different service, to remove dependency on mempool and messagequeue
176+
// Idea: Create a service that aggregates a bunch of different sources
174177
@trace("block.collect_inputs")
175178
private async collectProductionData(): Promise<{
176179
txs: PendingTransaction[];
@@ -199,7 +202,10 @@ export class BlockProducerModule extends SequencerModule<BlockConfig> {
199202
};
200203
}
201204

202-
const messages = await this.messageService.getPendingMessages();
205+
let messages: PendingTransaction[] = [];
206+
if (this.messageService !== undefined) {
207+
messages = await this.messageService.getPendingMessages();
208+
}
203209

204210
log.debug(
205211
`Block collected, ${txs.length} txs, ${messages.length} messages`

packages/sequencer/src/settlement/SettlementModule.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ import { ProvenSettlementPermissions } from "./permissions/ProvenSettlementPermi
4646
import { SignedSettlementPermissions } from "./permissions/SignedSettlementPermissions";
4747
import { SettlementUtils } from "./utils/SettlementUtils";
4848
import { BridgingModule } from "./BridgingModule";
49+
import { IncomingMessagesService } from "./messages/IncomingMessagesService";
4950

5051
export interface SettlementModuleConfig {
5152
feepayer: PrivateKey;
@@ -104,6 +105,9 @@ export class SettlementModule
104105
BridgingModule: {
105106
useClass: BridgingModule,
106107
},
108+
IncomingMessagesService: {
109+
useClass: IncomingMessagesService,
110+
},
107111
};
108112
}
109113

packages/sequencer/src/settlement/messages/IncomingMessagesService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { SettlementStorage } from "../../storage/repositories/SettlementStorage"
55
import { MessageStorage } from "../../storage/repositories/MessageStorage";
66
import { BlockStorage } from "../../storage/repositories/BlockStorage";
77
import { PendingTransaction } from "../../mempool/PendingTransaction";
8-
import { SettlementModule } from "../SettlementModule";
8+
import type { SettlementModule } from "../SettlementModule";
99

1010
import { IncomingMessageAdapter } from "./IncomingMessageAdapter";
1111

packages/sequencer/src/worker/worker/FlowTaskWorker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class FlowTaskWorker<Tasks extends Task<any, any>[]>
9393
log.debug(`Preparing task ${task.constructor.name}`);
9494
// eslint-disable-next-line no-await-in-loop
9595
await task.prepare();
96-
log.trace(`${task.constructor.name} prepared`);
96+
log.debug(`${task.constructor.name} prepared`);
9797
}
9898

9999
const newWorkers = Object.fromEntries(

packages/stack/src/scripts/graphql/server.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,9 @@ export async function startServer() {
196196
url: "http://localhost:4318",
197197
},
198198
},
199+
metrics: {
200+
enabled: true,
201+
},
199202
},
200203

201204
Database: {

0 commit comments

Comments
 (0)