Skip to content

Commit b1ab0d2

Browse files
committed
Removed redis pwd
1 parent c02d00d commit b1ab0d2

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/pull-request-develop.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ jobs:
100100
POSTGRES_URL: postgres
101101
REDIS_URL: redis
102102
DATABASE_URL: "postgresql://admin:password@postgres:5432/protokit?schema=public"
103+
REDIS_CI: true
103104

104105
services:
105106
postgres:
@@ -112,8 +113,6 @@ jobs:
112113
- 5432:5432
113114
redis:
114115
image: redis:6.2-alpine
115-
options: >-
116-
--requirepass password
117116
ports:
118117
- 6379:6379
119118

packages/persistance/src/RedisConnection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { RedisMerkleTreeStore } from "./services/redis/RedisMerkleTreeStore";
99

1010
export interface RedisConnectionConfig {
1111
host: string;
12-
password: string;
12+
password?: string;
1313
port?: number;
1414
username?: string;
1515
}

packages/persistance/test-integration/utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ import {
3131

3232
const prismaUrl = process.env["POSTGRES_URL"];
3333
const redisUrl = process.env["REDIS_URL"];
34+
// We don't use the password for CI runs
35+
const redisCI = process.env["REDIS_CI"];
3436

3537
const prismaConfig = {
3638
host: prismaUrl ?? "localhost",
@@ -45,7 +47,7 @@ const prismaConfig = {
4547
const redisConfig = {
4648
host: redisUrl ?? "localhost",
4749
port: 6379,
48-
password: "password",
50+
password: redisCI ? undefined : "password",
4951
};
5052

5153
export const IntegrationTestDBConfig = {

0 commit comments

Comments
 (0)