Merge branch 'develop' into feature/proven-settlemnet

# Conflicts:
#	packages/sequencer/src/protocol/production/BlockTaskFlowService.ts
#	packages/sequencer/src/protocol/production/tasks/StateTransitionTask.ts

Author: rpanic

packages/common/src/config/ModuleContainer.ts

@@ -454,8 +454,6 @@ export class ModuleContainer<
     );
   }
 
-  protected createSuperClassAliases(module: any) {}
-
   /**
    * This is a placeholder for individual modules to override.
    * This method will be called whenever the underlying container fully

packages/common/src/utils.ts

@@ -19,6 +19,10 @@ export function requireTrue(
   }
 }
 
+/**
+ * Utility function to split an array of type T into a record <K, T[]> based on a
+ * function T => K that determines the key of each record
+ */
 export function splitArray<T, K extends string | number>(
   arr: T[],
   split: (t: T) => K

packages/sequencer/src/protocol/production/BlockTaskFlowService.ts

@@ -9,7 +9,7 @@ import {
   Protocol,
   StateTransitionProof,
 } from "@proto-kit/protocol";
-import { log, MAX_FIELD, MOCK_PROOF } from "@proto-kit/common";
+import { log, MAX_FIELD } from "@proto-kit/common";
 
 import { TaskQueue } from "../../worker/queue/TaskQueue";
 import { Flow, FlowCreator } from "../../worker/flow/Flow";
@@ -215,11 +215,7 @@ export class BlockTaskFlowService {
       this.flowCreator
     );
     blockMergingFlow.onCompletion(async (result) => {
-      const printableProof =
-        result.proof === MOCK_PROOF
-          ? result.proof
-          : result.toJSON().proof.slice(100);
-      log.debug(`Block generation finished, with proof ${printableProof}`); // TODO Remove result logging
+      log.debug(`Block generation finished, with proof ${result.proof}`); // TODO Remove result logging
       flow.resolve(result);
     });
     blockMergingFlow.deferErrorsTo(flow);

packages/sequencer/src/sequencer/executor/Sequencer.ts

@@ -66,6 +66,14 @@ export class Sequencer<Modules extends SequencerModulesRecord>
    * modules to start each
    */
   public async start() {
+    // The sequencer uses tsyringe to resolve modules (and their dependencies)
+    // and then starts them. However, this can be problematic as although tsyringe may resolve
+    // dependencies, it doesn't actually start them. For example, a database may be created,
+    // but the connection strings, etc, won't be constructed until it's started, and this may
+    // cause an error if a module that relies on it is started first. The way to fix this is
+    // ensure that we start modules based on the order they were resolved.
+    // We iterate through the methods three times:
+
     this.useDependencyFactory(this.container.resolve(MethodIdFactory));
 
     // Log startup info
@@ -75,15 +83,41 @@ export class Sequencer<Modules extends SequencerModulesRecord>
     log.info("Starting sequencer...");
     log.info("Modules:", moduleClassNames);
 
+    // Iteration #1: We invoke the afterResolution feature for the container
+    // to ensure every time a module is resolved it gets recorded.
+    const orderedModules: Extract<keyof Modules, string>[] = [];
+    // eslint-disable-next-line guard-for-in
+    for (const moduleName in this.definition.modules) {
+      this.container.afterResolution(
+        moduleName,
+        () => {
+          orderedModules.push(moduleName);
+        },
+        {
+          frequency: "Once",
+        }
+      );
+    }
+    // Iteration #2: We resolve each module and thus populate
+    // the orderedModules list to understand the sequencing.
     // eslint-disable-next-line guard-for-in
     for (const moduleName in this.definition.modules) {
       const sequencerModule = this.resolve(moduleName);
-
       log.info(
-        `Starting sequencer module ${moduleName} (${sequencerModule.constructor.name})`
+        `Resolving sequencer module ${moduleName} (${sequencerModule.constructor.name})`
       );
+    }
+
+    // Iteration #3: We now iterate though the orderedModules list
+    // and start the modules in the order they were resolved.
+    for (const moduleName of orderedModules) {
+      const sequencerModule = this.resolve(moduleName);
       // eslint-disable-next-line no-await-in-loop
       await sequencerModule.start();
+
+      log.info(
+        `Starting sequencer module ${moduleName} (${sequencerModule.constructor.name})`
+      );
     }
   }
 }

packages/sequencer/test/settlement/MinaActionsHashList.test.ts

@@ -1,3 +1,4 @@
+import "reflect-metadata";
 import {
   ACTIONS_EMPTY_HASH,
   MinaActions,

packages/stack/package.json

@@ -2,7 +2,7 @@
   "name": "@proto-kit/stack",
   "version": "0.1.1-develop.833+397881ed",
   "license": "MIT",
-  "private": false,
+  "private": true,
   "type": "module",
   "scripts": {
     "build": "tsc -p tsconfig.json",