Skip to content

Update State Storage to use Linked Merkle Tree (WIP) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ejMina226 wants to merge 109 commits into from
Closed

Update State Storage to use Linked Merkle Tree (WIP) #211

ejMina226 wants to merge 109 commits into from

Conversation

@ejMina226
Copy link
Contributor

@ejMina226 ejMina226 commented Oct 25, 2024 •
edited
Loading

This change allows us to reduce the size of the state storage tree from 2256 to 240 , without fear of hash-collisions. These smaller trees will provide significant improvements to the performance (e.g. less hashing in circuits).

See #222 as well

Outstanding tasks:

  • Issue with the SettlementTest
  • Optimise code
  • Adding Redis

@ejMina226 ejMina226 self-assigned this Oct 25, 2024
@ejMina226 ejMina226 linked an issue Oct 25, 2024 that may be closed by this pull request
Add linked merkle tree as the primary state tree for the protocol #191
Closed
@ejMina226
Define Leaf
7dcca53
@ejMina226
Start LinkedMerkleTree
11922ac
@ejMina226
Start LinkedMerkleTree
e78afb7
@ejMina226
Create LinkedMerkleTreeStore
36d07bc
@ejMina226
Update LinkedMerkleTreeStore
fba3f7c
@ejMina226
Update interface with types.
da6d00c
@ejMina226
Update interface and get implementation for in memory linked merkle tree
da3f1ab
@ejMina226
Update interface
ae09af0
@ejMina226
Working on LinkedMerkleTree
1c1ab2d
@ejMina226
Add in getClosestPath
13f61a1
@ejMina226
Update GetWitness
69dbaaa
@ejMina226
Added in code to set leaf
d8930c0
@ejMina226
Remove deleted reference
162ab7d
@ejMina226
Set up constructor
4527044
@ejMina226
Set up constructor and fix initialisation
ba198a9
@ejMina226
Add in private
671f563
@ejMina226
Update comment
7c7c791
@ejMina226
Update comment
bffd5d4
@ejMina226
Change confusing method name
743935d
@ejMina226
Adding setValue
1dfdcb4
@ejMina226
Changing setValue to insert and update
2423256
@ejMina226
Change getPathLessOrEqual to include equal
c1dc6ee
@ejMina226
Change types as path and nextPath are bigint and not number
1c3e27e
@ejMina226
Update state transition prover to use LinkedMerkleTree
af96307
@ejMina226
Add types
396c01f
@ejMina226
Remove unnecessary code
5f3f6a2
@ejMina226
Add in-circuit checks for reading
72011b4
@ejMina226 ejMina226 marked this pull request as ready for review December 2, 2024 09:17
@ejMina226 ejMina226 changed the title Update State Storage to use Linked Merkle Tree Update State Storage to use Linked Merkle Tree (WIP) Jan 22, 2025
@rpanic
Copy link
Member

rpanic commented Apr 11, 2025

Closed in favor of #303, which builds on top of this PR

@rpanic rpanic closed this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ejMina226 ejMina226

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add linked merkle tree as the primary state tree for the protocol

3 participants

@ejMina226 @rpanic