-
Notifications
You must be signed in to change notification settings - Fork 15
Contract deployment check #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9da9bd to
638e16e
Compare
rpanic
requested changes
Dec 11, 2025
rpanic
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We needed a way to check if the keys in the settlement module configuration are indeed private keys of contracts deployed on L1. To make it, a small function is implemented, which checks the deployment via network configuration in
MinaBaseLayerThis PR closes #352
Commit Descriptions
Added token contract addresses getter: b4e2780. If there are no keys, an empty array is returned.
Deployment check function is added 0ffc741. It is configured to check both:
hasAccountmethodfetchAccountsmethod by using network configurations given in theSettlement.test.tsAdded test cases to check the deployment before and after deployment d9da9bd