Skip to content

Commit 2d92fd1

Browse files
committed
see if IAsyncDisposable is the CI blocker
1 parent 93ab2aa commit 2d92fd1

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

tests/protobuf-net.Grpc.Test.Integration/Issues/Issue100.cs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
using Grpc.Core;
22
using ProtoBuf;
3+
using ProtoBuf.Grpc.Client;
34
using ProtoBuf.Grpc.Configuration;
4-
using System;
5-
using System.Threading.Tasks;
65
using ProtoBuf.Grpc.Server;
7-
using Xunit;
8-
using ProtoBuf.Grpc.Client;
9-
using Xunit.Abstractions;
106
using ProtoBuf.Meta;
7+
using System;
118
using System.Buffers;
12-
using Xunit.Sdk;
139
using System.IO;
1410
using System.Runtime.InteropServices;
11+
using System.Threading.Tasks;
12+
using Xunit;
13+
using Xunit.Abstractions;
1514

1615
#nullable disable
1716

@@ -82,9 +81,9 @@ public Issue100(Issue100ServerFixture server, ITestOutputHelper log)
8281
GrpcClientFactory.AllowUnencryptedHttp2 = true;
8382
}
8483

85-
public class Issue100ServerFixture : ITest, IAsyncDisposable
84+
public class Issue100ServerFixture : ITest, IDisposable
8685
{
87-
public ValueTask DisposeAsync() => new ValueTask(_server.KillAsync());
86+
public void Dispose() => _ = _server.KillAsync();
8887

8988
private readonly Server? _server;
9089
public Issue100ServerFixture()

tests/protobuf-net.Grpc.Test.Integration/Issues/Issue75_Exceptions.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
using Grpc.Core;
2-
using ProtoBuf;
32
using ProtoBuf.Grpc.Client;
43
using ProtoBuf.Grpc.Configuration;
54
using ProtoBuf.Grpc.Server;
65
using System;
76
using System.Threading.Tasks;
87
using Xunit;
9-
using Xunit.Abstractions;
108

119
#nullable disable
1210

@@ -40,9 +38,9 @@ public Issue75(Issue75ServerFixture serverFixture)
4038
GrpcClientFactory.AllowUnencryptedHttp2 = true;
4139
}
4240

43-
public class Issue75ServerFixture : IFaultTest, IInterceptedFaultTest, IAsyncDisposable
41+
public class Issue75ServerFixture : IFaultTest, IInterceptedFaultTest, IDisposable
4442
{
45-
public ValueTask DisposeAsync() => new ValueTask(_server.KillAsync());
43+
public void Dispose() => _ = _server.KillAsync();
4644

4745
private readonly Server? _server;
4846
public Issue75ServerFixture()

0 commit comments

Comments
 (0)