use volatile for _headersTaskOrSource

mgravell · mgravell · commit f8e5978e5c30 · 2020-10-06T11:53:27.000+01:00
diff --git a/src/protobuf-net.Grpc/Internal/MetadataContext.cs b/src/protobuf-net.Grpc/Internal/MetadataContext.cs
@@ -27,7 +27,7 @@ internal Metadata Headers
 
         internal Task<Metadata>? GetHeadersTask(bool createIfMissing)
         {
-            return _headersTaskOrSource switch
+            return Volatile.Read(ref _headersTaskOrSource) switch
             {
                 Task<Metadata> task => task,
                 TaskCompletionSource<Metadata> tcs => tcs.Task,
@@ -60,7 +60,7 @@ internal MetadataContext Reset()
         {
             Status = Status.DefaultSuccess;
             _trailers = null;
-            _headersTaskOrSource = null;
+            Volatile.Write(ref _headersTaskOrSource, null);
             return this;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ internal Metadata Headers`
`27`	`27`
`28`	`28`	`internal Task<Metadata>? GetHeadersTask(bool createIfMissing)`
`29`	`29`	`{`
`30`		`- return _headersTaskOrSource switch`
	`30`	`+ return Volatile.Read(ref _headersTaskOrSource) switch`
`31`	`31`	`{`
`32`	`32`	`Task<Metadata> task => task,`
`33`	`33`	`TaskCompletionSource<Metadata> tcs => tcs.Task,`
`@@ -60,7 +60,7 @@ internal MetadataContext Reset()`
`60`	`60`	`{`
`61`	`61`	`Status = Status.DefaultSuccess;`
`62`	`62`	`_trailers = null;`
`63`		`- _headersTaskOrSource = null;`
	`63`	`+ Volatile.Write(ref _headersTaskOrSource, null);`
`64`	`64`	`return this;`
`65`	`65`	`}`
`66`	`66`